[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vmbus: Don't make QOM property registration conditional
|
From: |
Maciej S. Szmigiero |
|
Subject: |
Re: [PATCH] vmbus: Don't make QOM property registration conditional |
|
Date: |
Sun, 11 Oct 2020 01:30:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 09.10.2020 23:33, Eduardo Habkost wrote:
> On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote:
>> On 09.10.2020 22:07, Eduardo Habkost wrote:
>>> Having properties registered conditionally makes QOM type
>>> introspection difficult. Instead of skipping registration of the
>>> "instanceid" property, always register the property but validate
>>> its value against the instance id required by the class.
>>>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>> ---
>>> Note: due to the lack of concrete vmbus-dev subclasses in the
>>> QEMU tree, this patch couldn't be tested.
>>
>> Will test it tomorrow since I have a VMBus device implementation.
>
> Thanks!
>
Tested the patch with a hv-balloon device and is seems to work okay, so:
Acked-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Maciej