Re: [PULL 00/39] SCSI, qdev, qtest, meson patches for 2020-10-10

[no-reply]

Patchew URL: 
20201010075739.951385-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20201010075739.951385-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201010075739.951385-1-pbonzini@redhat.com
Subject: [PULL 00/39] SCSI, qdev, qtest, meson patches for 2020-10-10

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      
patchew/1602059975-10115-1-git-send-email-chenhc@lemote.com -> 
patchew/1602059975-10115-1-git-send-email-chenhc@lemote.com
 * [new tag]         patchew/20201010075739.951385-1-pbonzini@redhat.com -> 
patchew/20201010075739.951385-1-pbonzini@redhat.com
 * [new tag]         patchew/20201010080623.768-1-jiangyifei@huawei.com -> 
patchew/20201010080623.768-1-jiangyifei@huawei.com
Switched to a new branch 'test'
55f98d2 meson: identify more sections of meson.build
3f959b1 scsi/scsi_bus: fix races in REPORT LUNS
41c759b virtio-scsi: use scsi_device_get
17f4dca scsi/scsi_bus: Add scsi_device_get
eafe5c7 scsi/scsi-bus: scsi_device_find: don't return unrealized devices
c8ddbc5 device-core: use atomic_set on .realized property
07df212 scsi: switch to bus->check_address
a7baa24 device-core: use RCU for list of children of a bus
bbd9350 device_core: use drain_call_rcu in in qmp_device_add
7cafd84 scsi/scsi_bus: switch search direction in scsi_device_find
9ef1542 qdev: add "check if address free" callback for buses
1d6727d qemu-iotests, qtest: rewrite test 067 as a qtest
96b23e6 qtest: check that drives are really appearing and disappearing
a6d906c qtest: switch users back to qtest_qmp_receive
fcf3581 device-plug-test: use qtest_qmp to send the device_del command
3722046 qtest: remove qtest_qmp_receive_success
17077b6 qtest: Reintroduce qtest_qmp_receive
5b850fc qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict
940c32f meson.build: Re-enable KVM support for MIPS
b4cd071 build-sys: fix git version from -version
e81db1e docs/devel: update instruction on how to add new unit tests
f187a57 qtest: unify extra_qtest_srcs and extra_qtest_deps
80c356b docs/devel/qtest: Include libqtest API reference
ef6b5cb docs/devel/qtest: Include protocol spec in document
7f82ce7 docs: Move QTest documentation to its own document
d5fddc0 configure: fix performance regression due to PIC objects
70cd0b9 qom: fix objects with improper parent type
a63dc48 exec: split out non-softmmu-specific parts
6a633f6 softmmu: move more files to softmmu/
32c750b hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE
85a528c qom: Move the creation of the library to the main meson.build
6d611b1 authz: Move the creation of the library to the main meson.build
d597f26 crypto: Move the creation of the library to the main meson.build
d44bc2e io: Move the creation of the library to the main meson.build
6f014b0 migration: Move the creation of the library to the main meson.build
9d197f1 chardev: Move the creation of the library to the main meson.build
8b9a449 hw/core: Move the creation of the library to the main meson.build
245f27b meson.build: Sort sourcesets alphabetically
cbc9573 meson.build: Add comments to clarify code organization

=== OUTPUT BEGIN ===
1/39 Checking commit cbc957397c02 (meson.build: Add comments to clarify code 
organization)
2/39 Checking commit 245f27b24fa7 (meson.build: Sort sourcesets alphabetically)
3/39 Checking commit 8b9a44915aa8 (hw/core: Move the creation of the library to 
the main meson.build)
4/39 Checking commit 9d197f154484 (chardev: Move the creation of the library to 
the main meson.build)
5/39 Checking commit 6f014b047dde (migration: Move the creation of the library 
to the main meson.build)
6/39 Checking commit d44bc2e97f1c (io: Move the creation of the library to the 
main meson.build)
7/39 Checking commit d597f26a6c94 (crypto: Move the creation of the library to 
the main meson.build)
8/39 Checking commit 6d611b137d38 (authz: Move the creation of the library to 
the main meson.build)
9/39 Checking commit 85a528c294eb (qom: Move the creation of the library to the 
main meson.build)
10/39 Checking commit 32c750b90a9c (hw/nvram: Always register 
FW_CFG_DATA_GENERATOR_INTERFACE)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 55 lines checked

Patch 10/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/39 Checking commit 6a633f68ddd7 (softmmu: move more files to softmmu/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#85: 
rename from bootdevice.c

total: 0 errors, 1 warnings, 69 lines checked

Patch 11/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/39 Checking commit a63dc48247ea (exec: split out non-softmmu-specific parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#104: FILE: cpu.c:48:
+    /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the

WARNING: Block comments use * on subsequent lines
#105: FILE: cpu.c:49:
+    /* 0x01 was CPU_INTERRUPT_EXIT. This line can be removed when the
+       version_id is increased. */

WARNING: Block comments use a trailing */ on a separate line
#105: FILE: cpu.c:49:
+       version_id is increased. */

WARNING: Block comments use a leading /* on a separate line
#109: FILE: cpu.c:53:
+    /* loadvm has just updated the content of RAM, bypassing the

ERROR: spaces required around that '*' (ctx:VxV)
#175: FILE: cpu.c:119:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

WARNING: Block comments use a leading /* on a separate line
#205: FILE: cpu.c:149:
+    /* Create a memory property for softmmu CPU object,

WARNING: Block comments use a leading /* on a separate line
#393: FILE: cpu.c:337:
+/* enable or disable single step mode. EXCP_DEBUG is returned by the

WARNING: Block comments use * on subsequent lines
#394: FILE: cpu.c:338:
+/* enable or disable single step mode. EXCP_DEBUG is returned by the
+   CPU loop after each instruction */

WARNING: Block comments use a trailing */ on a separate line
#394: FILE: cpu.c:338:
+   CPU loop after each instruction */

ERROR: "foo * bar" should be "foo *bar"
#452: FILE: cpu.c:396:
+    void * p;

ERROR: braces {} are necessary for all arms of this statement
#458: FILE: cpu.c:402:
+        if (l > len)
[...]

ERROR: braces {} are necessary for all arms of this statement
#461: FILE: cpu.c:405:
+        if (!(flags & PAGE_VALID))
[...]

ERROR: braces {} are necessary for all arms of this statement
#464: FILE: cpu.c:408:
+            if (!(flags & PAGE_WRITE))
[...]

ERROR: do not use assignment in if condition
#467: FILE: cpu.c:411:
+            if (!(p = lock_user(VERIFY_WRITE, addr, l, 0)))

ERROR: braces {} are necessary for all arms of this statement
#467: FILE: cpu.c:411:
+            if (!(p = lock_user(VERIFY_WRITE, addr, l, 0)))
[...]

ERROR: braces {} are necessary for all arms of this statement
#472: FILE: cpu.c:416:
+            if (!(flags & PAGE_READ))
[...]

ERROR: do not use assignment in if condition
#475: FILE: cpu.c:419:
+            if (!(p = lock_user(VERIFY_READ, addr, l, 1)))

ERROR: braces {} are necessary for all arms of this statement
#475: FILE: cpu.c:419:
+            if (!(p = lock_user(VERIFY_READ, addr, l, 1)))
[...]

WARNING: Block comments use a leading /* on a separate line
#499: FILE: cpu.c:443:
+    /* NOTE: we can always suppose that qemu_host_page_size >=

WARNING: Block comments use * on subsequent lines
#500: FILE: cpu.c:444:
+    /* NOTE: we can always suppose that qemu_host_page_size >=
+       TARGET_PAGE_SIZE */

WARNING: Block comments use a trailing */ on a separate line
#500: FILE: cpu.c:444:
+       TARGET_PAGE_SIZE */

total: 10 errors, 12 warnings, 1061 lines checked

Patch 12/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/39 Checking commit 70cd0b9ec467 (qom: fix objects with improper parent type)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 13/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/39 Checking commit d5fddc0cba63 (configure: fix performance regression due 
to PIC objects)
15/39 Checking commit 7f82ce732ca7 (docs: Move QTest documentation to its own 
document)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 124 lines checked

Patch 15/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/39 Checking commit ef6b5cbd233f (docs/devel/qtest: Include protocol spec in 
document)
17/39 Checking commit 80c356b3fbc1 (docs/devel/qtest: Include libqtest API 
reference)
18/39 Checking commit f187a576c59c (qtest: unify extra_qtest_srcs and 
extra_qtest_deps)
19/39 Checking commit e81db1ec6da4 (docs/devel: update instruction on how to 
add new unit tests)
20/39 Checking commit b4cd071db805 (build-sys: fix git version from -version)
21/39 Checking commit 940c32fa7664 (meson.build: Re-enable KVM support for MIPS)
22/39 Checking commit 5b850fc17469 (qtest: rename qtest_qmp_receive to 
qtest_qmp_receive_dict)
23/39 Checking commit 17077b686545 (qtest: Reintroduce qtest_qmp_receive)
24/39 Checking commit 372204626c2a (qtest: remove qtest_qmp_receive_success)
25/39 Checking commit fcf3581e19b2 (device-plug-test: use qtest_qmp to send the 
device_del command)
WARNING: line over 80 characters
#33: FILE: tests/qtest/device-plug-test.c:23:
+                     "{'execute': 'device_del', 'arguments': { 'id': %s } }", 
id);

total: 0 errors, 1 warnings, 76 lines checked

Patch 25/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/39 Checking commit a6d906ce8819 (qtest: switch users back to 
qtest_qmp_receive)
27/39 Checking commit 96b23e6b9397 (qtest: check that drives are really 
appearing and disappearing)
28/39 Checking commit 1d6727dc791e (qemu-iotests, qtest: rewrite test 067 as a 
qtest)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46: 
deleted file mode 100755

WARNING: line over 80 characters
#650: FILE: tests/qtest/drive_del-test.c:19:
+static bool look_for_drive0(QTestState *qts, const char *command, const char 
*key)

total: 0 errors, 2 warnings, 309 lines checked

Patch 28/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/39 Checking commit 9ef154286ce3 (qdev: add "check if address free" callback 
for buses)
30/39 Checking commit 7cafd8471e6a (scsi/scsi_bus: switch search direction in 
scsi_device_find)
31/39 Checking commit bbd93507e2d4 (device_core: use drain_call_rcu in in 
qmp_device_add)
32/39 Checking commit a7baa24616a2 (device-core: use RCU for list of children 
of a bus)
33/39 Checking commit 07df2121d569 (scsi: switch to bus->check_address)
ERROR: code indent should never use tabs
#55: FILE: hw/scsi/scsi-bus.c:137:
+^I^I^I^I     int channel, int target, int lun,$

ERROR: code indent should never use tabs
#56: FILE: hw/scsi/scsi-bus.c:138:
+^I^I^I^I     SCSIDevice **p_dev)$

WARNING: line over 80 characters
#71: FILE: hw/scsi/scsi-bus.c:153:
+static bool scsi_bus_check_address(BusState *qbus, DeviceState *qdev, Error 
**errp)

WARNING: line over 80 characters
#91: FILE: hw/scsi/scsi-bus.c:173:
+        if (!scsi_bus_is_address_free(bus, dev->channel, dev->id, dev->lun, 
&d)) {

WARNING: line over 80 characters
#130: FILE: hw/scsi/scsi-bus.c:195:
+            is_free = scsi_bus_is_address_free(bus, dev->channel, ++id, 
dev->lun, NULL);

WARNING: line over 80 characters
#143: FILE: hw/scsi/scsi-bus.c:205:
+            is_free = scsi_bus_is_address_free(bus, dev->channel, dev->id, 
++lun, NULL);

total: 2 errors, 4 warnings, 182 lines checked

Patch 33/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

34/39 Checking commit c8ddbc5cad10 (device-core: use atomic_set on .realized 
property)
35/39 Checking commit eafe5c7675d0 (scsi/scsi-bus: scsi_device_find: don't 
return unrealized devices)
36/39 Checking commit 17f4dca5c0be (scsi/scsi_bus: Add scsi_device_get)
37/39 Checking commit 41c759b9e570 (virtio-scsi: use scsi_device_get)
38/39 Checking commit 3f959b1165c9 (scsi/scsi_bus: fix races in REPORT LUNS)
39/39 Checking commit 55f98d22596c (meson: identify more sections of 
meson.build)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201010075739.951385-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201010075739.951385-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com