Re: [RFC PATCH 0/4] generic loader FDT support (for direct Xen boot)

[no-reply]

Patchew URL: 
20201009170742.23695-1-alex.bennee@linaro.org/">https://patchew.org/QEMU/20201009170742.23695-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201009170742.23695-1-alex.bennee@linaro.org
Subject: [RFC PATCH  0/4] generic loader FDT support (for direct Xen boot)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201009170742.23695-1-alex.bennee@linaro.org -> 
patchew/20201009170742.23695-1-alex.bennee@linaro.org
Switched to a new branch 'test'
8fbccbe generic_loader: allow the insertion of /chosen/module stanzas
2baf07a device_tree: add qemu_fdt_setprop_string_array helper
dd6eea3 hw/riscv: migrate fdt field to generic MachineState
dd8ee86 hw/board: promote fdt from ARM VirtMachineState to MachineState

=== OUTPUT BEGIN ===
1/4 Checking commit dd8ee86f5cdf (hw/board: promote fdt from ARM 
VirtMachineState to MachineState)
2/4 Checking commit dd6eea3e6e34 (hw/riscv: migrate fdt field to generic 
MachineState)
3/4 Checking commit 2baf07a7abfc (device_tree: add 
qemu_fdt_setprop_string_array helper)
WARNING: line over 80 characters
#35: FILE: device_tree.c:406:
+int qemu_fdt_setprop_string_array(void *fdt, const char *node_path, const char 
*prop,

total: 0 errors, 1 warnings, 61 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 8fbccbec9628 (generic_loader: allow the insertion of 
/chosen/module stanzas)
ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' 
prefix instead
#51: FILE: hw/core/generic-loader.c:73:
+    g_autofree char *node = g_strdup_printf("/chosen/module@%#08lx", s->addr);

WARNING: line over 80 characters
#71: FILE: hw/core/generic-loader.c:93:
+        if (qemu_fdt_setprop_string(fdt, node, "bootargs", s->fdt_bootargs) < 
0) {

total: 1 errors, 1 warnings, 76 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201009170742.23695-1-alex.bennee@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201009170742.23695-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com