[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] authz-list-file: Fix crash when filename is not set
From: |
Li Qiang |
Subject: |
Re: [PATCH 1/3] authz-list-file: Fix crash when filename is not set |
Date: |
Fri, 9 Oct 2020 23:06:23 +0800 |
Eduardo Habkost <ehabkost@redhat.com> 于2020年10月9日周五 上午4:28写道:
>
> Fix the following crash:
>
> $ qemu-system-x86_64 -object authz-list-file,id=obj0
> qemu-system-x86_64: -object authz-list-file,id=obj0: GLib:
> g_file_get_contents: assertion 'filename != NULL' failed
> Segmentation fault (core dumped)
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> authz/listfile.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/authz/listfile.c b/authz/listfile.c
> index cd6163aa40..aaf930453d 100644
> --- a/authz/listfile.c
> +++ b/authz/listfile.c
> @@ -122,6 +122,11 @@ qauthz_list_file_complete(UserCreatable *uc, Error
> **errp)
> QAuthZListFile *fauthz = QAUTHZ_LIST_FILE(uc);
> gchar *dir = NULL, *file = NULL;
>
> + if (!fauthz->filename) {
> + error_setg(errp, "filename not provided");
> + return;
> + }
> +
> fauthz->list = qauthz_list_file_load(fauthz, errp);
>
> if (!fauthz->refresh) {
> --
> 2.26.2
>
>