Re: does make check now require TCG? Or is it a parallelism issue?

[Claudio Fontana]

On 10/8/20 5:02 PM, Paolo Bonzini wrote:
> On 08/10/20 16:48, Claudio Fontana wrote:
>> on master, a build without tcg like:
>>
>> exec '../configure' '--disable-tcg' '--enable-kvm' '--enable-hax' "$@"
>>
>> make -j120 check
>> Generating qemu-version.h with a meson_exe.py custom command
>> make: *** No rule to make target 'qemu-system-aarch64', needed by 
>> 'check-block'.  Stop.
>> make: *** Waiting for unfinished jobs....
>>
>> qemu-system-aarch64 is required for check-block now?
> 
> No, it's not, it's an unnecessary dependency.  This will fix it:
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 5aca98e60c..1ca70d88ce 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -140,7 +140,7 @@ QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = 
> tests/qemu-iotests/socket_scm_helper$(EXE
>  check: check-block
>  check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \
>               qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
> -             $(patsubst %-softmmu,qemu-system-%,$(filter 
> %-softmmu,$(TARGET_DIRS)))
> +             qemu-system-$(patsubst ppc64%,ppc64, $(shell uname -m))
>       @$<
>  endif
>  
> 
> 

thanks this works!

>> If I run without -j:
>>
>> Running test qtest-i386: qmp-cmd-test
>> Broken pipe
>> ../tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 
>> (Aborted) (core dumped)
>> ERROR qtest-i386: qmp-cmd-test - too few tests run (expected 53, got 45)
>> make: *** [Makefile.mtest:1074: run-test-151] Error 1
> 
> This one is different and I've never seen it.

This one seems an additional, non-tcg build only error, will update when I have 
more details.

> 
> Paolo
> 

Ciao,

Claudio