Re: [PATCH v5 18/36] qapi: establish mypy type-checking baseline

[Markus Armbruster]

John Snow <jsnow@redhat.com> writes:

> On 10/7/20 5:25 AM, Markus Armbruster wrote:
>> John Snow <jsnow@redhat.com> writes:
>> 
>>> Fix two very minor issues,
>> What are the two issues?  I'm asking because I can see only one.
>> 
>
> Bitrot! The other one got fixed elsewhere and rebase didn't conflict,
> so I didn't update the commit message.
>
>>>                             and then establish a mypy type-checking
>>> baseline.
>> Any particular reason this can't go before PATCH 15 "qapi/common.py: add
>> type hint annotations".
>> 
>
> Just the way the chips fell. common.py does not check until this very
> commit.
>
> Adding a mypy config can be shuffled up earlier and earlier by
> determining which checks to ignore and adding them, but I'm not sure
> who that benefits.

I like symmetry, but it's okay as is.  I asked to make sure I'm not
missing something more subtle.

[...]