Re: [PATCH 20/20] python: add mypy config

[John Snow]

On 10/7/20 7:35 AM, Kevin Wolf wrote:
> Am 07.10.2020 um 01:58 hat John Snow geschrieben:
> > Formalize the options used for checking the python library. You can run
> > mypy from the directory that mypy.ini is in by typing `mypy qemu/`.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   python/mypy.ini | 4 ++++
> >   1 file changed, 4 insertions(+)
> >   create mode 100644 python/mypy.ini
> >
> > diff --git a/python/mypy.ini b/python/mypy.ini
> > new file mode 100644
> > index 00000000000..7a70eca47c6
> > --- /dev/null
> > +++ b/python/mypy.ini
> > @@ -0,0 +1,4 @@
> > +[mypy]
> > +strict = True
>
> $ mypy --strict qemu
> mypy.ini: [mypy]: Strict mode is not supported in configuration files: specify 
> individual flags instead (see 'mypy -h' for the list of flags enabled in strict 
> mode)
> Success: no issues found in 6 source files
> $ mypy --version
> mypy 0.740
>
> Did this change in newer mypy versions? I guess it's time that I get the
> new laptop which will involve installing a newer Fedora release. :-)
>
> > +python_version = 3.6
> > +warn_unused_configs = True
> > \ No newline at end of file
>
> Kevin

0.770 lets you use strict in the config file. Fairly modern. I intend to 
use this version in the CI venv that I am cooking up to check these, so 
no need to hurry and update your fedora.

'pip3 install --user mypy>=0.770' should work out just fine until then.

Maybe I should drop back down to >=0.730, but I liked being able to 
force the stricter options in the conf file directly. I also liked the 
idea that if new strict options got added in the future, we'd acquire 
them automatically.

I felt like anything we disabled should be a conscious and explicit 
choice, instead of the opposite.

--js