[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 10/19] multi-process: introduce proxy object
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v10 10/19] multi-process: introduce proxy object |
Date: |
Wed, 7 Oct 2020 15:37:38 +0100 |
On Mon, Oct 05, 2020 at 11:50:58AM -0700, elena.ufimtseva@oracle.com wrote:
> +static void pci_proxy_dev_realize(PCIDevice *device, Error **errp)
> +{
> + PCIProxyDev *dev = PCI_PROXY_DEV(device);
> + int fd;
> +
> + if (dev->fd) {
> + fd = monitor_fd_param(cur_mon, dev->fd, errp);
> + if (fd == -1) {
> + error_prepend(errp, "proxy: unable to parse fd: ");
> + return;
> + }
> + proxy_set_socket(dev, fd, errp);
> + } else {
> + error_setg(errp, "fd parameter not specified for %s",
> + DEVICE(device)->id);
> + return;
> + }
> +
> + error_setg(&dev->migration_blocker, "%s does not support migration",
> + TYPE_PCI_PROXY_DEV);
> + if (migrate_add_blocker(dev->migration_blocker, errp)) {
> + error_free(dev->migration_blocker);
> + error_free(*errp);
> + dev->migration_blocker = NULL;
> + error_setg(errp, "Failed to set migration blocker");
> + }
> +
> + qemu_mutex_init(&dev->io_mutex);
> + qio_channel_set_blocking(dev->ioc, true, NULL);
> +}
> +
> +static void pci_proxy_dev_exit(PCIDevice *pdev)
> +{
> + PCIProxyDev *dev = PCI_PROXY_DEV(pdev);
> +
> + qio_channel_close(dev->ioc, NULL);
Call migrate_del_blocker() and delete dev->migration_blocker?
signature.asc
Description: PGP signature
- [PATCH v10 01/19] memory: alloc RAM from file at offset, (continued)
- [PATCH v10 01/19] memory: alloc RAM from file at offset, elena . ufimtseva, 2020/10/05
- [PATCH v10 07/19] multi-process: Initialize message handler in remote device, elena . ufimtseva, 2020/10/05
- [PATCH v10 03/19] multi-process: setup PCI host bridge for remote device, elena . ufimtseva, 2020/10/05
- [PATCH v10 05/19] multi-process: add qio channel function to transmit, elena . ufimtseva, 2020/10/05
- [PATCH v10 08/19] multi-process: Associate fd of a PCIDevice with its object, elena . ufimtseva, 2020/10/05
- [PATCH v10 09/19] multi-process: setup memory manager for remote device, elena . ufimtseva, 2020/10/05
- [PATCH v10 12/19] multi-process: Forward PCI config space acceses to the remote process, elena . ufimtseva, 2020/10/05
- [PATCH v10 10/19] multi-process: introduce proxy object, elena . ufimtseva, 2020/10/05
- Re: [PATCH v10 10/19] multi-process: introduce proxy object,
Stefan Hajnoczi <=
- [PATCH v10 14/19] multi-process: Synchronize remote memory, elena . ufimtseva, 2020/10/05
- [PATCH v10 16/19] multi-process: Retrieve PCI info from remote process, elena . ufimtseva, 2020/10/05
- [PATCH v10 15/19] multi-process: create IOHUB object to handle irq, elena . ufimtseva, 2020/10/05
- [PATCH v10 04/19] multi-process: setup a machine object for remote device process, elena . ufimtseva, 2020/10/05
- [PATCH v10 11/19] multi-process: add proxy communication functions, elena . ufimtseva, 2020/10/05
- [PATCH v10 13/19] multi-process: PCI BAR read/write handling for proxy & remote endpoints, elena . ufimtseva, 2020/10/05
- [PATCH v10 17/19] multi-process: perform device reset in the remote process, elena . ufimtseva, 2020/10/05
- [PATCH v10 19/19] multi-process: add configure and usage information, elena . ufimtseva, 2020/10/05
- [PATCH v10 18/19] multi-process: add the concept description to docs/devel/qemu-multiprocess, elena . ufimtseva, 2020/10/05
- Re: [PATCH v10 00/19] Initial support for multi-process Qemu, Stefan Hajnoczi, 2020/10/07