[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 00/20] s390x/tcg: Implement Vector enhancements facility a
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v1 00/20] s390x/tcg: Implement Vector enhancements facility and switch to z14 |
Date: |
Wed, 7 Oct 2020 15:09:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 01.10.20 17:07, Richard Henderson wrote:
> On 9/30/20 9:55 AM, David Hildenbrand wrote:
>> This series adds support for the "Vector enhancements facility" and bumps
>> the qemu CPU model tp to a stripped-down z14.
>>
>> I yet have to find a way to get more test coverage - looks like some of
>> the functions aren't used anywhere yet (e.g., VECTOR FP MAXIMUM), writing
>> unit tests to cover all functions and cases is just nasty. But I might be
>> wrong - I'm planning to at least test basic functionality of all new added
>> instructions.
>
> This is where RISU can be helpful. Auto-generate 100k random variations,
> record known good results on hardware, verify that replay on qemu produces the
> same results.
Makes sense, however, some corner cases (e.g., MAX(+0, -O)) still might
have to be handled manually.
It might take me a while to address the feedback (I'm fairly busy as
usual ...). Thanks!
--
Thanks,
David / dhildenb