Re: [PATCH v2 3/5] nbd: Simplify meta-context parsing

[Vladimir Sementsov-Ogievskiy]

30.09.2020 15:11, Eric Blake wrote:
> We had a premature optimization of trying to read as little from the
> wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases.
> But in reality, we HAVE to read the entire string from the client
> before we can get to the next command, and it is easier to just read
> it all at once than it is to read it in pieces.  And once we do that,
> several functions end up no longer performing I/O, so they can drop
> length and errp parameters, and just return a bool instead of
> modifying through a pointer.
>
> Our iotests still pass; I also checked that libnbd's testsuite (which
> covers more corner cases of odd meta context requests) still passes.

Also, do not advertise bitmaps meta context when bitmap export is not set.

> Signed-off-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir