Re: acceptance-system-fedora failures

[Philippe Mathieu-Daudé]

On 10/7/20 9:23 AM, Thomas Huth wrote:
> On 07/10/2020 07.20, Philippe Mathieu-Daudé wrote:
>> On 10/7/20 1:07 AM, John Snow wrote:
>>> I'm seeing this gitlab test fail quite often in my Python work; I don't
>>> *think* this has anything to do with my patches, but maybe I need to try
>>> and bisect this more aggressively.
> [...]
>> w.r.t. the error in your build, I told Thomas about the
>> test_ppc_mac99/day15/invaders.elf timeouting but he said this is
>> not his area. Richard has been looking yesterday to see if it is
>> a TCG regression, and said the test either finished/crashed raising
>> SIGCHLD, but Avocado parent is still waiting for a timeout, so the
>> children become zombie and the test hang.
>>
>> Not sure that helps :)
> 
> No clue why that invaders.elf is now failing with the replay test, but if
> you look at the history of the CI runs:
> 
>  https://gitlab.com/qemu-project/qemu/-/pipelines
> 
> ... you can clearly see that the problem started with John's
> ide-pull-request 5 days ago:
> 
>  https://gitlab.com/qemu-project/qemu/-/pipelines/197124608
> 
> So maybe it's worth the effort to have a look at the patches that got merged
> here?

Great idea!

Bisected using:

$ make qemu-system-ppc check-venv && \
  tests/venv/bin/python -m \
  avocado --show=app,console,replay \
  run -t machine:mac99 \
  tests/acceptance/replay_kernel.py

55adb3c45620c31f29978f209e2a44a08d34e2da is the first bad commit
commit 55adb3c45620c31f29978f209e2a44a08d34e2da
Author: John Snow <jsnow@redhat.com>
Date:   Fri Jul 24 01:23:00 2020 -0400

    ide: cancel pending callbacks on SRST

    The SRST implementation did not keep up with the rest of IDE;
    it is possible to perform a weak reset on an IDE device to
    remove the BSY/DRQ bits, and then issue writes to the
    control/device registers which can cause chaos with the state
    machine.

    Fix that by actually performing a real reset.

    Reported-by: Alexander Bulekov <alxndr@bu.edu>
    Fixes: https://bugs.launchpad.net/qemu/+bug/1878253
    Fixes: https://bugs.launchpad.net/qemu/+bug/1887303
    Fixes: https://bugs.launchpad.net/qemu/+bug/1887309
    Signed-off-by: John Snow <jsnow@redhat.com>

 hw/ide/core.c | 58
++++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 40 insertions(+), 18 deletions(-)

Regards,

Phil.