Re: [PATCH] Changes to support booting NetBSD/alpha

[no-reply]

Patchew URL: 20201007032417.26044-1-thorpej@me.com/">https://patchew.org/QEMU/20201007032417.26044-1-thorpej@me.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201007032417.26044-1-thorpej@me.com
Subject: [PATCH] Changes to support booting NetBSD/alpha

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201007032417.26044-1-thorpej@me.com -> 
patchew/20201007032417.26044-1-thorpej@me.com
Switched to a new branch 'test'
a3c92d1 Changes to support booting NetBSD/alpha

=== OUTPUT BEGIN ===
WARNING: Block comments use a leading /* on a separate line
#51: FILE: hw/alpha/dp264.c:75:
+    /* arg0 -> memory size

WARNING: Block comments use * on subsequent lines
#52: FILE: hw/alpha/dp264.c:76:
+    /* arg0 -> memory size
+       arg1 -> kernel entry point

ERROR: code indent should never use tabs
#56: FILE: hw/alpha/dp264.c:80:
+^I^I    bit  6   -> nographics option (for HWRPB CTB)$

WARNING: Block comments use a trailing */ on a separate line
#58: FILE: hw/alpha/dp264.c:82:
+       See init_hwrpb() in the PALcode.  */

ERROR: suspect code indent for conditional statements (4, 6)
#63: FILE: hw/alpha/dp264.c:87:
+    if (!machine->enable_graphics)
+      cpus[0]->env.trap_arg2 |= (1 << 6);

ERROR: braces {} are necessary for all arms of this statement
#63: FILE: hw/alpha/dp264.c:87:
+    if (!machine->enable_graphics)
[...]

WARNING: Block comments use a leading /* on a separate line
#67: FILE: hw/alpha/dp264.c:90:
+    /* Init the chipset.  Because we're using CLIPPER IRQ mappings,

WARNING: Block comments use * on subsequent lines
#68: FILE: hw/alpha/dp264.c:91:
+    /* Init the chipset.  Because we're using CLIPPER IRQ mappings,
+       the minimum PCI device IdSel is 1.  */

WARNING: Block comments use a trailing */ on a separate line
#68: FILE: hw/alpha/dp264.c:91:
+       the minimum PCI device IdSel is 1.  */

WARNING: Block comments use a leading /* on a separate line
#103: FILE: hw/alpha/typhoon.c:925:
+    /* Init the PCI-ISA bridge.  Technically, this would have been

WARNING: Block comments use * on subsequent lines
#104: FILE: hw/alpha/typhoon.c:926:
+    /* Init the PCI-ISA bridge.  Technically, this would have been
+       a cy82c693ub, but a i82378 SIO was also used on many Alpha

WARNING: Block comments use a trailing */ on a separate line
#112: FILE: hw/alpha/typhoon.c:934:
+       it to be there will see it.  */

WARNING: Block comments use a leading /* on a separate line
#125: FILE: hw/alpha/typhoon.c:970:
+/* The following was copied from hw/isa/i82378.c and modified to provide

WARNING: Block comments use * on subsequent lines
#126: FILE: hw/alpha/typhoon.c:971:
+/* The following was copied from hw/isa/i82378.c and modified to provide
+   only the minimal PCI device node.  */

WARNING: Block comments use a trailing */ on a separate line
#126: FILE: hw/alpha/typhoon.c:971:
+   only the minimal PCI device node.  */

ERROR: trailing whitespace
#128: FILE: hw/alpha/typhoon.c:973:
+/*                            $

ERROR: trailing whitespace
#129: FILE: hw/alpha/typhoon.c:974:
+ * QEMU Intel i82378 emulation (PCI to ISA bridge) $

ERROR: trailing whitespace
#130: FILE: hw/alpha/typhoon.c:975:
+ *                            $

ERROR: trailing whitespace
#132: FILE: hw/alpha/typhoon.c:977:
+ *  $

ERROR: trailing whitespace
#137: FILE: hw/alpha/typhoon.c:982:
+ *  $

ERROR: trailing whitespace
#142: FILE: hw/alpha/typhoon.c:987:
+ *     $

ERROR: trailing whitespace
#145: FILE: hw/alpha/typhoon.c:990:
+ */    $

ERROR: trailing whitespace
#162: FILE: hw/alpha/typhoon.c:1007:
+        VMSTATE_PCI_DEVICE(parent_obj, I82378State), $

ERROR: trailing whitespace
#164: FILE: hw/alpha/typhoon.c:1009:
+    },                        $

ERROR: trailing whitespace
#165: FILE: hw/alpha/typhoon.c:1010:
+};                            $

ERROR: trailing whitespace
#170: FILE: hw/alpha/typhoon.c:1015:
+ $

ERROR: trailing whitespace
#176: FILE: hw/alpha/typhoon.c:1021:
+ $

ERROR: trailing whitespace
#182: FILE: hw/alpha/typhoon.c:1027:
+}      $

ERROR: trailing whitespace
#185: FILE: hw/alpha/typhoon.c:1030:
+{   $

ERROR: trailing whitespace
#189: FILE: hw/alpha/typhoon.c:1034:
+    k->realize = i82378_realize; $

ERROR: trailing whitespace
#196: FILE: hw/alpha/typhoon.c:1041:
+}                             $

ERROR: trailing whitespace
#206: FILE: hw/alpha/typhoon.c:1051:
+        { },     $

ERROR: trailing whitespace
#208: FILE: hw/alpha/typhoon.c:1053:
+};  $

ERROR: if this code is redundant consider removing it
#226: FILE: hw/rtc/mc146818rtc.c:158:
+#if 0

total: 22 errors, 12 warnings, 192 lines checked

Commit a3c92d1aa5e6 (Changes to support booting NetBSD/alpha) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201007032417.26044-1-thorpej@me.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201007032417.26044-1-thorpej@me.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com