[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 00/36] qapi: static typing conversion, pt1
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v5 00/36] qapi: static typing conversion, pt1 |
Date: |
Tue, 6 Oct 2020 13:51:15 -0400 |
On Mon, Oct 05, 2020 at 07:57:18PM -0400, John Snow wrote:
> On 10/5/20 7:05 PM, Cleber Rosa wrote:
> > Here on patches 08 an later, I've run:
> >
> > flake8 ./scripts/qapi
> >
> > And starting on patch 24 ("qapi/source.py: add type hint annotations")
> > it complained about:
> >
> > /scripts/qapi/source.py:44:31: F821 undefined name 'T'
>
> I think that must be flake8 < 3.8.0. Try using >= 3.8.0.
>
ACK, I was on 3.7.9. They're all passing now with 3.8.4.
- Cleber.
signature.asc
Description: PGP signature
- [PATCH v5 33/36] qapi/types.py: remove one-letter variables, (continued)
- [PATCH v5 33/36] qapi/types.py: remove one-letter variables, John Snow, 2020/10/05
- [PATCH v5 35/36] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/10/05
- [PATCH v5 36/36] qapi/visit.py: add type hint annotations, John Snow, 2020/10/05
- Re: [PATCH v5 00/36] qapi: static typing conversion, pt1, Cleber Rosa, 2020/10/05
- Re: [PATCH v5 00/36] qapi: static typing conversion, pt1, Markus Armbruster, 2020/10/07