Re: [PATCH v10.5 0/1] tests/tcg/aarch64: Add bti mmap smoke test

[no-reply]

Patchew URL: 
20201006172359.2998-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20201006172359.2998-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201006172359.2998-1-richard.henderson@linaro.org
Subject: [PATCH v10.5 0/1] tests/tcg/aarch64: Add bti mmap smoke test

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201005165147.526426-1-clg@kaod.org -> 
patchew/20201005165147.526426-1-clg@kaod.org
 - [tag update]      patchew/20201005205228.697463-1-ehabkost@redhat.com -> 
patchew/20201005205228.697463-1-ehabkost@redhat.com
 - [tag update]      patchew/20201006154256.17392-1-alex.bennee@linaro.org -> 
patchew/20201006154256.17392-1-alex.bennee@linaro.org
 * [new tag]         patchew/20201006172359.2998-1-richard.henderson@linaro.org 
-> patchew/20201006172359.2998-1-richard.henderson@linaro.org
Switched to a new branch 'test'
bef94f7 tests/tcg/aarch64: Add bti mmap smoke test

=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

ERROR: externs should be avoided in .c files
#96: FILE: tests/tcg/aarch64/bti-2.c:56:
+extern char test_begin[], test_end[];

ERROR: use qemu_real_host_page_size instead of getpagesize()
#130: FILE: tests/tcg/aarch64/bti-2.c:90:
+    void *p = mmap(0, getpagesize(),

total: 2 errors, 1 warnings, 124 lines checked

Commit bef94f733a7f (tests/tcg/aarch64: Add bti mmap smoke test) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201006172359.2998-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201006172359.2998-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com