[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTER
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 1/1] hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE |
Date: |
Tue, 6 Oct 2020 18:08:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/6/20 6:04 PM, Laszlo Ersek wrote:
> On 10/06/20 17:51, Richard Henderson wrote:
>> On 10/6/20 10:36 AM, Philippe Mathieu-Daudé wrote:
>>> +++ b/hw/nvram/fw_cfg-interface.c
>>> @@ -0,0 +1,15 @@
>>> +#include "qemu/osdep.h"
>>> +#include "hw/nvram/fw_cfg.h"
>>
>> License boilerplate missing.
>>
>> r~
>>
>
> Hrmpf, so easy to forget about that, especially in review :/
Although easily scriptable if we consider SPDX identifiers...
> Thanks for
> catching it.
>
> Laszlo
>
Re: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon, no-reply, 2020/10/06