Re: [PATCH 00/10] meson: Move the creation of the library to the main meson.build

[Paolo Bonzini]

On 06/10/20 13:12, Philippe Mathieu-Daudé wrote:
> Make Meson machinery more consistent, as requested by Paolo.
> 
> Philippe Mathieu-Daudé (10):
>   migration: Only add migration files to the Meson sourceset
>   meson.build: Add comments to clarify code organization
>   meson.build: Sort sourcesets alphabetically
>   hw/core: Move the creation of the library to the main meson.build
>   chardev: Move the creation of the library to the main meson.build
>   migration: Move the creation of the library to the main meson.build
>   io: Move the creation of the library to the main meson.build
>   crypto: Move the creation of the library to the main meson.build
>   authz: Move the creation of the library to the main meson.build
>   qom: Move the creation of the library to the main meson.build
> 
>  meson.build           | 86 ++++++++++++++++++++++++++++++++++++++-----
>  authz/meson.build     | 10 -----
>  chardev/meson.build   |  6 ---
>  crypto/meson.build    | 10 -----
>  hw/core/meson.build   |  6 ---
>  io/meson.build        | 10 -----
>  migration/meson.build |  8 +---
>  qom/meson.build       |  8 ----
>  8 files changed, 77 insertions(+), 67 deletions(-)
> 

Nice!  Apart from the change to patch 1, perhaps move the "Targets"
headline a little earlier, namely just before

foreach m : block_mods + softmmu_mods
...
endforeach

Thanks!

Paolo