[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] softmmu: move more files to softmmu/
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/2] softmmu: move more files to softmmu/ |
Date: |
Tue, 6 Oct 2020 12:02:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/6/20 11:54 AM, Paolo Bonzini wrote:
> On 06/10/20 11:43, BALATON Zoltan wrote:
>>
>> The name of this dir may be misleading. I think it originally stood
>> for the actual MMU emulation but now it seems everything related to
>> system emulation is dumped here. Is it better to keep MMU emulation
>> separate and put other files in a "sysemu" dir or rename this dir if
>> it keeps mixing MMU emulation and system emulation parts? (I think
>> the MMU emulation is a weak part of QEMU regarding performance so it
>> would be better to keep that cleanly separated so that it's easier to
>> analyse and optimise it in the future, which is more difficult if
>> it's mixed with other parts where it's not even clear what
>> constitutes the actual MMU emulation. So I vote for keeping it
>> separate.)
>
> I agree that softmmu/ should have been called sysemu/. But I think it's
> unnecessary churn to do that now.
It is not necessary, but there are so many files moved around recently
so it is not a bad time to clarify it neither :)
OTOH yes many files have been moved around recently, so we might wait
for the next release before attacking this cleanup.
>
> Paolo
>
>