[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 13/36] qapi/common.py: Replace one-letter 'c' variable
From: |
John Snow |
Subject: |
[PATCH v5 13/36] qapi/common.py: Replace one-letter 'c' variable |
Date: |
Mon, 5 Oct 2020 15:51:35 -0400 |
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
scripts/qapi/common.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
index a417b6029c8..338adedef4f 100644
--- a/scripts/qapi/common.py
+++ b/scripts/qapi/common.py
@@ -30,14 +30,14 @@ def camel_to_upper(value):
new_name = ''
length = len(c_fun_str)
for i in range(length):
- c = c_fun_str[i]
- # When c is upper and no '_' appears before, do more checks
- if c.isupper() and (i > 0) and c_fun_str[i - 1] != '_':
+ char = c_fun_str[i]
+ # When char is upper case and no '_' appears before, do more checks
+ if char.isupper() and (i > 0) and c_fun_str[i - 1] != '_':
if i < length - 1 and c_fun_str[i + 1].islower():
new_name += '_'
elif c_fun_str[i - 1].isdigit():
new_name += '_'
- new_name += c
+ new_name += char
return new_name.lstrip('_').upper()
--
2.26.2
- Re: [PATCH v5 08/36] qapi: delint using flake8, (continued)
[PATCH v5 12/36] qapi/common.py: delint with pylint, John Snow, 2020/10/05
[PATCH v5 13/36] qapi/common.py: Replace one-letter 'c' variable,
John Snow <=
[PATCH v5 14/36] qapi/common.py: check with pylint, John Snow, 2020/10/05
[PATCH v5 15/36] qapi/common.py: add type hint annotations, John Snow, 2020/10/05
[PATCH v5 16/36] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/10/05
[PATCH v5 17/36] qapi/common.py: move build_params into gen.py, John Snow, 2020/10/05