[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/tcg/linux-test: Adjust getsockname for musl
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] tests/tcg/linux-test: Adjust getsockname for musl |
|
Date: |
Mon, 5 Oct 2020 19:23:15 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/5/20 6:58 PM, Richard Henderson wrote:
> Unlike glibc, musl does not use transparent unions to hide
> the different structures that overlap struct sockaddr.
>
> Add an explicit cast to work around this.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/tcg/multiarch/linux-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/linux-test.c
> b/tests/tcg/multiarch/linux-test.c
> index 8a7c15cd31..96bbad5823 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -296,7 +296,7 @@ static void test_socket(void)
> server_fd = server_socket();
> /* find out what port we got */
> socklen = sizeof(server_addr);
> - ret = getsockname(server_fd, &server_addr, &socklen);
> + ret = getsockname(server_fd, (struct sockaddr *)&server_addr, &socklen);
> chk_error(ret);
> server_port = ntohs(server_addr.sin_port);
>
>