Re: [PATCH] tests: tcg: do not use implicit rules

[Philippe Mathieu-Daudé]

On 10/3/20 10:50 AM, Paolo Bonzini wrote:
> Use pattern rules to clarify which targets are going to match the
> rule and to provide clearer error messages.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  tests/Makefile.include | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 40d909badc..5aca98e60c 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -50,21 +50,21 @@ RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, 
> $(TARGET_DIRS))
>  $(foreach PROBE_TARGET,$(TARGET_DIRS),                               \
>       $(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs))
>  
> -build-tcg-tests-%: $(if $(CONFIG_PLUGIN),test-plugins)
> +$(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if 
> $(CONFIG_PLUGIN),test-plugins)
>       $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
>               -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
>               SRC_PATH=$(SRC_PATH) \
>               V="$(V)" TARGET="$*" guest-tests, \
>               "BUILD", "TCG tests for $*")
>  
> -run-tcg-tests-%: build-tcg-tests-% all
> +$(RUN_TCG_TARGET_RULES): run-tcg-tests-%: build-tcg-tests-% all
>       $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
>               -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
>               SRC_PATH=$(SRC_PATH) SPEED="$(SPEED)" \
>               V="$(V)" TARGET="$*" run-guest-tests, \
>               "RUN", "TCG tests for $*")
>  
> -clean-tcg-tests-%:
> +$(CLEAN_TCG_TARGET_RULES): clean-tcg-tests-%:
>       $(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) \
>               -f $(SRC_PATH)/tests/tcg/Makefile.qemu \
>               SRC_PATH=$(SRC_PATH) TARGET="$*" clean-guest-tests, \
>