Re: [RFC PATCH v4 00/29] Hexagon patch series

[Richard Henderson]

On 9/28/20 12:28 PM, Taylor Simpson wrote:
> This series adds support for the Hexagon processor with Linux user support
> 
> See patch 02/34 Hexagon README for detailed information.
> 
> Once the series is applied, the Hexagon port will pass "make check-tcg".
> The series also includes Hexagon-specific tests in tcg/tests/hexagon.
> 
> The series is also available at https://github.com/quic/qemu on branch
> small_series_v4.

BTW, some whitespace warnings when applying this series.


r~


> Applying: Hexagon Update MAINTAINERS file
> Applying: Hexagon (target/hexagon) README
> .git/rebase-apply/patch:247: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (include/elf.h) ELF machine definition
> Applying: Hexagon (target/hexagon) scalar core definition
> Applying: Hexagon (disas) disassembler
> .git/rebase-apply/patch:87: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (target/hexagon) register names
> Applying: Hexagon (target/hexagon) scalar core helpers
> .git/rebase-apply/patch:431: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (target/hexagon) GDB Stub
> Applying: Hexagon (target/hexagon) architecture types
> Applying: Hexagon (target/hexagon) instruction and packet types
> Applying: Hexagon (target/hexagon) register fields
> .git/rebase-apply/patch:132: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (target/hexagon) instruction attributes
> .git/rebase-apply/patch:149: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (target/hexagon) instruction/packet decode
> Applying: Hexagon (target/hexagon) instruction printing
> .git/rebase-apply/patch:136: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (target/hexagon) utility functions
> .git/rebase-apply/patch:512: new blank line at EOF.
> +
> .git/rebase-apply/patch:887: new blank line at EOF.
> +
> .git/rebase-apply/patch:1670: new blank line at EOF.
> +
> warning: 3 lines add whitespace errors.
> Applying: Hexagon (target/hexagon/imported) arch import
> .git/rebase-apply/patch:598: space before tab in indent.
>                       
> fSETBYTE(i,RdV,fSATUB(fGETHALF(i,RssV)+fGETHALF(i,RttV)));
> .git/rebase-apply/patch:1329: space before tab in indent.
>                        RdV = RsV;
> .git/rebase-apply/patch:6793: space before tab in indent.
>       sys_icinva(thread, (REG),insn->slot);
> .git/rebase-apply/patch:7280: space before tab in indent.
>                          fMPY16SS(fGETBYTE(1,RssV),fGETUBYTE(1,RttV)))));
> .git/rebase-apply/patch:7282: space before tab in indent.
>                          fMPY16SS(fGETBYTE(3,RssV),fGETUBYTE(3,RttV)))));
> warning: squelched 41 whitespace errors
> warning: 46 lines add whitespace errors.
> Applying: Hexagon (target/hexagon) generator phase 1 - C preprocessor for 
> semantics
> Applying: Hexagon (target/hexagon) generator phase 2 - generate header files
> Applying: Hexagon (target/hexagon) generator phase 3 - C preprocessor for 
> decode tree
> Applying: Hexagon (target/hexagon) generater phase 4 - decode tree
> Applying: Hexagon (target/hexagon) opcode data structures
> Applying: Hexagon (target/hexagon) macros
> Applying: Hexagon (target/hexagon) instruction classes
> .git/rebase-apply/patch:141: new blank line at EOF.
> +
> .git/rebase-apply/patch:199: new blank line at EOF.
> +
> warning: 2 lines add whitespace errors.
> Applying: Hexagon (target/hexagon) TCG generation
> Applying: Hexagon (target/hexagon) TCG for instructions with multiple 
> definitions
> Applying: Hexagon (target/hexagon) translation
> Applying: Hexagon (linux-user/hexagon) Linux user emulation
> .git/rebase-apply/patch:405: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon (tests/tcg/hexagon) TCG tests
> .git/rebase-apply/patch:1314: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
> Applying: Hexagon build infrastructure