[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v2 16/16] pci: Let pci_dma_write() propagate MemTxResult
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH RESEND v2 16/16] pci: Let pci_dma_write() propagate MemTxResult |
Date: |
Thu, 1 Oct 2020 19:25:19 +0200 |
pci_dma_rw() returns a MemTxResult type.
Do not discard it, return it to the caller.
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pci.h | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 299df068c9..8114313e1e 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -819,8 +819,20 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev,
dma_addr_t addr,
return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
}
-static inline int pci_dma_write(PCIDevice *dev, dma_addr_t addr,
- const void *buf, dma_addr_t len)
+/**
+ * pci_dma_write: Write to address space from PCI device.
+ *
+ * Return a MemTxResult indicating whether the operation succeeded
+ * or failed (eg unassigned memory, device rejected the transaction,
+ * IOMMU fault).
+ *
+ * @dev: #PCIDevice doing the memory access
+ * @addr: address within the #PCIDevice address space
+ * @buf: buffer with the data transferred
+ * @len: the number of bytes to write
+ */
+static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr,
+ const void *buf, dma_addr_t len)
{
return pci_dma_rw(dev, addr, (void *) buf, len, DMA_DIRECTION_FROM_DEVICE);
}
--
2.26.2
- [PATCH RESEND v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes, (continued)
- [PATCH RESEND v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 06/16] dma: Let dma_memory_read() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 07/16] dma: Let dma_memory_write() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 09/16] dma: Let dma_memory_set() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 08/16] dma: Let dma_memory_valid() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 10/16] dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 11/16] dma: Let dma_memory_rw() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 13/16] dma: Let dma_memory_map() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 12/16] dma: Let dma_memory_read/write() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 15/16] pci: Let pci_dma_read() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 16/16] pci: Let pci_dma_write() propagate MemTxResult,
Philippe Mathieu-Daudé <=
- [PATCH RESEND v2 14/16] pci: Let pci_dma_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- Re: [PATCH RESEND v2 00/16] hw: Let DMA/PCI API take MemTxAttrs argument and propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/22