[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_r
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_rw |
Date: |
Thu, 1 Oct 2020 19:25:04 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Some might actually care about the return value of dma_memory_rw. So
let us pass it along instead of ignoring it.
There are no existing users of the return value, so this patch should be
safe.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Keith Busch <kbusch@kernel.org>
Message-Id: <20191011070141.188713-2-its@irrelevant.dk>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/hw/pci/pci.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 0a59a06b14..f19ffe6b4f 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -783,8 +783,7 @@ static inline AddressSpace *pci_get_address_space(PCIDevice
*dev)
static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr,
void *buf, dma_addr_t len, DMADirection dir)
{
- dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
- return 0;
+ return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir);
}
static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr,
--
2.26.2
- [PATCH RESEND v2 00/16] hw: Let DMA/PCI API take MemTxAttrs argument and propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 01/16] pci: pass along the return value of dma_memory_rw,
Philippe Mathieu-Daudé <=
- [PATCH RESEND v2 02/16] docs/devel/loads-stores: Add regexp for DMA functions, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 04/16] dma: Let dma_memory_set() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 05/16] dma: Let dma_memory_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 03/16] dma: Document address_space_map/address_space_unmap() prototypes, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 06/16] dma: Let dma_memory_read() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 07/16] dma: Let dma_memory_write() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 09/16] dma: Let dma_memory_set() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 08/16] dma: Let dma_memory_valid() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 10/16] dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01
- [PATCH RESEND v2 11/16] dma: Let dma_memory_rw() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/10/01