[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code |
Date: |
Thu, 01 Oct 2020 07:04:32 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> In commit f68c01470b we restricted the query-uuid command to
> machine code, but it is incorrect, as it is also used by the
> tools. Therefore move this command again, but to block.json,
> which is shared by machine code and tools.
>
> Fixes: f68c01470b ("qapi: Restrict query-uuid command to machine code")
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
UUIDs are not really a block-specific thing.
QMP query-uuid and HMP info uuid are about the VM, like query-name.
That's why they used to be next to query-name in misc.json.
There's one additional use in block/iscsi.c's get_initiator_name(). I
figure that's what pulls it into tools via qemu-img.
Which other QAPI modules are shared by all the executables that use it?
What about reverting the commit? How bad would that be for user mode?
- Re: [PATCH v3 01/11] qapi: Restrict query-uuid command to block code,
Markus Armbruster <=