[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 03/18] qom: Allow class type name to be specified in OBJECT_DE
From: |
Eduardo Habkost |
Subject: |
[PATCH v4 03/18] qom: Allow class type name to be specified in OBJECT_DECLARE* |
Date: |
Mon, 31 Aug 2020 17:07:25 -0400 |
Many QOM types don't follow the Type/TypeClass pattern
on the instance/struct names. Let the class struct name
be specified in the OBJECT_DECLARE* macros.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v3 -> v4: none
Changes v2 -> v3: none
Changes v1 -> v2: none
---
include/qom/object.h | 35 ++++++++++++++++++-----------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/include/qom/object.h b/include/qom/object.h
index f515230f61..500e7dfa99 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -555,7 +555,8 @@ struct Object
/**
* OBJECT_DECLARE_TYPE:
- * @ModuleObjName: the object name with initial capitalization
+ * @InstanceType: instance struct name
+ * @ClassType: class struct name
* @module_obj_name: the object name in lowercase with underscore separators
* @MODULE_OBJ_NAME: the object name in uppercase with underscore separators
*
@@ -567,33 +568,33 @@ struct Object
*
* The object struct and class struct need to be declared manually.
*/
-#define OBJECT_DECLARE_TYPE(ModuleObjName, module_obj_name, MODULE_OBJ_NAME) \
- typedef struct ModuleObjName ModuleObjName; \
- typedef struct ModuleObjName##Class ModuleObjName##Class; \
+#define OBJECT_DECLARE_TYPE(InstanceType, ClassType, module_obj_name,
MODULE_OBJ_NAME) \
+ typedef struct InstanceType InstanceType; \
+ typedef struct ClassType ClassType; \
\
- G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName, object_unref) \
+ G_DEFINE_AUTOPTR_CLEANUP_FUNC(InstanceType, object_unref) \
\
- static inline G_GNUC_UNUSED ModuleObjName##Class * \
+ static inline G_GNUC_UNUSED ClassType * \
MODULE_OBJ_NAME##_GET_CLASS(void *obj) \
- { return OBJECT_GET_CLASS(ModuleObjName##Class, obj, \
+ { return OBJECT_GET_CLASS(ClassType, obj, \
TYPE_##MODULE_OBJ_NAME); } \
\
- static inline G_GNUC_UNUSED ModuleObjName##Class * \
+ static inline G_GNUC_UNUSED ClassType * \
MODULE_OBJ_NAME##_CLASS(void *klass) \
- { return OBJECT_CLASS_CHECK(ModuleObjName##Class, klass, \
+ { return OBJECT_CLASS_CHECK(ClassType, klass, \
TYPE_##MODULE_OBJ_NAME); } \
\
- static inline G_GNUC_UNUSED ModuleObjName * \
+ static inline G_GNUC_UNUSED InstanceType * \
MODULE_OBJ_NAME(void *obj) \
- { return OBJECT_CHECK(ModuleObjName, obj, \
+ { return OBJECT_CHECK(InstanceType, obj, \
TYPE_##MODULE_OBJ_NAME); }
/**
* OBJECT_DECLARE_SIMPLE_TYPE:
- * @ModuleObjName: the object name with initial caps
+ * @InstanceType: instance struct name
* @module_obj_name: the object name in lowercase with underscore separators
* @MODULE_OBJ_NAME: the object name in uppercase with underscore separators
- * @ParentModuleObjName: the parent object name with initial caps
+ * @ParentClassType: class struct name of parent type
*
* This does the same as OBJECT_DECLARE_TYPE(), but also declares
* the class struct, thus only the object struct needs to be declare
@@ -602,10 +603,10 @@ struct Object
* This macro should be used unless the class struct needs to have
* virtual methods declared.
*/
-#define OBJECT_DECLARE_SIMPLE_TYPE(ModuleObjName, module_obj_name, \
- MODULE_OBJ_NAME, ParentModuleObjName) \
- OBJECT_DECLARE_TYPE(ModuleObjName, module_obj_name, MODULE_OBJ_NAME) \
- struct ModuleObjName##Class { ParentModuleObjName##Class parent_class; };
+#define OBJECT_DECLARE_SIMPLE_TYPE(InstanceType, module_obj_name, \
+ MODULE_OBJ_NAME, ParentClassType) \
+ OBJECT_DECLARE_TYPE(InstanceType, InstanceType##Class, module_obj_name,
MODULE_OBJ_NAME) \
+ struct InstanceType##Class { ParentClassType parent_class; };
/**
--
2.26.2
- [PATCH v4 00/18] qom: Automated conversion of type checking boilerplate, Eduardo Habkost, 2020/08/31
- [PATCH v4 03/18] qom: Allow class type name to be specified in OBJECT_DECLARE*,
Eduardo Habkost <=
- [PATCH v4 01/18] qom: make object_ref/unref use a void * instead of Object *., Eduardo Habkost, 2020/08/31
- [PATCH v4 07/18] [automated] Delete duplicate QOM typedefs, Eduardo Habkost, 2020/08/31
- [PATCH v4 04/18] qom: DECLARE_*_CHECKERS macros, Eduardo Habkost, 2020/08/31
- [PATCH v4 05/18] qom: Make type checker functions accept const pointers, Eduardo Habkost, 2020/08/31
- [PATCH v4 02/18] qom: provide convenient macros for declaring and defining types, Eduardo Habkost, 2020/08/31
- [PATCH v4 06/18] codeconverter: script for automating QOM code cleanups, Eduardo Habkost, 2020/08/31
- [PATCH v4 09/18] [automated] Move QOM typedefs and add missing includes (pass 2), Eduardo Habkost, 2020/08/31
- [PATCH v4 10/18] [automated] Move QOM typedefs and add missing includes (pass 3), Eduardo Habkost, 2020/08/31
- [PATCH v4 08/18] [automated] Move QOM typedefs and add missing includes, Eduardo Habkost, 2020/08/31
- [PATCH v4 12/18] [automated] Use DECLARE_*CHECKER* macros (pass 2), Eduardo Habkost, 2020/08/31