[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/12] *** A Method for evaluating dirty page rate ***
From: |
David Edmondson |
Subject: |
Re: [PATCH v6 00/12] *** A Method for evaluating dirty page rate *** |
Date: |
Mon, 31 Aug 2020 10:05:30 +0100 |
Trying to think like a control plane developer and user (of which I am
neither) raised some questions about the overall interface provided
here. If everyone else is happy with the current interface, then I'll
shut up :-)
It seems like it should be possible to query the last measured dirty
rate at any time. In particular, it should be possible to query the
value before any rate has been measured (either returning an error, or
if that is unpalatable perhaps a result with a zero interval to indicate
"this data isn't useful"), but also *during* a subsequent measurement
period.
That is, the result of the previous measurement should always be
available on demand and a measurement becomes "current" when it
completes.
Given that we allow the caller to specify the measurement interval, some
callers might specify a long period. As only one measurement can be
taken at a time, a long running measurement rules out taking a short
measurement. That's probably okay, but does lead me to wonder whether
the API should include a mechanism allowing the cancellation of an
in-progress measurement.
dme.
--
I can't explain, you would not understand. This is not how I am.
- Re: [PATCH v6 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function, (continued)
- [PATCH v6 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE, Chuan Zheng, 2020/08/28
- [PATCH v6 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, Chuan Zheng, 2020/08/28
- [PATCH v6 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page, Chuan Zheng, 2020/08/28
- [PATCH v6 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug, Chuan Zheng, 2020/08/28
- [PATCH v6 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function, Chuan Zheng, 2020/08/28
- Re: [PATCH v6 00/12] *** A Method for evaluating dirty page rate ***,
David Edmondson <=