[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/18] Usb 20200828 patches
From: |
Gerd Hoffmann |
Subject: |
Re: [PULL 00/18] Usb 20200828 patches |
Date: |
Mon, 31 Aug 2020 10:31:02 +0200 |
On Fri, Aug 28, 2020 at 04:33:04PM +0200, Paolo Bonzini wrote:
> Il ven 28 ago 2020, 16:14 Peter Maydell <peter.maydell@linaro.org> ha
> scritto:
>
> > Why is Meson trying to use CMake here? I don't think we want
> > to bring in another build tool dependency...
> >
>
> It's asking cmake if it knows about the package, if pkg-config fails. This
> is because cmake has its own incompatible mechanism to tell users about
> compilation and linking flags, and the "dependency" line doesn't tell Meson
> if u2f-emu has a pkg-config or a cmake description.
It uses pkg-config, so we can explicitly say so.
> We can ask to use pkg-config only since none of our dependencies are
> cmake-only; see https://mesonbuild.com/Dependencies.html#dependency-method.
I'll send a new pull with that addressed (also the other 11/18 comments).
thanks,
Gerd
- [PULL 10/18] hw/usb: Add U2F key emulated mode, (continued)
- [PULL 10/18] hw/usb: Add U2F key emulated mode, Gerd Hoffmann, 2020/08/28
- [PULL 09/18] hw/usb: Add U2F key passthru mode, Gerd Hoffmann, 2020/08/28
- [PULL 11/18] meson: Add U2F key to meson, Gerd Hoffmann, 2020/08/28
- [PULL 07/18] hw/usb: Add U2F key base class, Gerd Hoffmann, 2020/08/28
- [PULL 12/18] docs/system: Add U2F key to the USB devices examples, Gerd Hoffmann, 2020/08/28
- [PULL 04/18] ehci: drop pointless warn_report for guest bugs., Gerd Hoffmann, 2020/08/28
- [PULL 05/18] hw/usb: Regroup USB HID protocol values, Gerd Hoffmann, 2020/08/28
- Re: [PULL 00/18] Usb 20200828 patches, Peter Maydell, 2020/08/28