[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode he
From: |
Richard Henderson |
Subject: |
Re: [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode helper function |
Date: |
Sat, 29 Aug 2020 17:18:05 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> From: Frank Chang <frank.chang@sifive.com>
>
> helper_set_rounding_mode() is responsible for SIGILL, and "round to odd"
> should be an interface private to translation, so add a new independent
> helper_set_rod_rounding_mode().
>
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> ---
> target/riscv/fpu_helper.c | 5 +++++
> target/riscv/helper.h | 1 +
> target/riscv/internals.h | 1 +
> target/riscv/translate.c | 5 +++++
> 4 files changed, 12 insertions(+)
...
> @@ -44,6 +44,7 @@ enum {
> FRM_RUP = 3, /* Round Up */
> FRM_RMM = 4, /* Round to Nearest, ties to Max Magnitude */
> FRM_DYN = 7, /* Dynamic rounding mode */
> + FRM_ROD = 8, /* Round to Odd */
> };
This needs a comment, or a rename, to indicate that it is private to qemu.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [RFC v4 60/70] target/riscv: rvv-1.0: remove integer extract instruction, (continued)
- [RFC v4 60/70] target/riscv: rvv-1.0: remove integer extract instruction, frank . chang, 2020/08/17
- [RFC v4 61/70] target/riscv: rvv-1.0: floating-point min/max instructions, frank . chang, 2020/08/17
- [RFC v4 62/70] target/riscv: introduce floating-point rounding mode enum, frank . chang, 2020/08/17
- [RFC v4 63/70] target/riscv: rvv-1.0: floating-point/integer type-convert instructions, frank . chang, 2020/08/17
- [RFC v4 64/70] target/riscv: rvv-1.0: widening floating-point/integer type-convert, frank . chang, 2020/08/17
- [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode helper function, frank . chang, 2020/08/17
- Re: [RFC v4 65/70] target/riscv: add "set round to odd" rounding mode helper function,
Richard Henderson <=
- [RFC v4 66/70] target/riscv: rvv-1.0: narrowing floating-point/integer type-convert, frank . chang, 2020/08/17
- [RFC v4 67/70] target/riscv: rvv-1.0: relax RV_VLEN_MAX to 512-bits, frank . chang, 2020/08/17
- [RFC v4 68/70] target/riscv: gdb: modify gdb csr xml file to align with csr register map, frank . chang, 2020/08/17
- [RFC v4 69/70] target/riscv: gdb: support vector registers for rv64, frank . chang, 2020/08/17
- [RFC v4 70/70] target/riscv: gdb: support vector registers for rv32, frank . chang, 2020/08/17