[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v4 55/70] target/riscv: rvv-1.0: single-width floating-point re
From: |
Richard Henderson |
Subject: |
Re: [RFC v4 55/70] target/riscv: rvv-1.0: single-width floating-point reduction |
Date: |
Sat, 29 Aug 2020 16:50:01 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> From: Frank Chang <frank.chang@sifive.com>
>
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> ---
> target/riscv/vector_helper.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
The one sentence in the manual is quite poor for this, and needs improvement:
> Floating-point max and min reductions should return the same final> value and
> raise the same exception flags regardless of operation
> order.
It doesn't actually say anything about the way in which we've implemented the
*_noprop functions.
Anyway,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [RFC v4 50/70] target/riscv: rvv-1.0: floating-point compare instructions, (continued)
- [RFC v4 50/70] target/riscv: rvv-1.0: floating-point compare instructions, frank . chang, 2020/08/17
- [RFC v4 51/70] target/riscv: rvv-1.0: mask-register logical instructions, frank . chang, 2020/08/17
- [RFC v4 52/70] target/riscv: rvv-1.0: slide instructions, frank . chang, 2020/08/17
- [RFC v4 53/70] target/riscv: rvv-1.0: floating-point slide instructions, frank . chang, 2020/08/17
- [RFC v4 54/70] target/riscv: rvv-1.0: narrowing fixed-point clip instructions, frank . chang, 2020/08/17
- [RFC v4 55/70] target/riscv: rvv-1.0: single-width floating-point reduction, frank . chang, 2020/08/17
- Re: [RFC v4 55/70] target/riscv: rvv-1.0: single-width floating-point reduction,
Richard Henderson <=
- [RFC v4 56/70] target/riscv: rvv-1.0: widening floating-point reduction instructions, frank . chang, 2020/08/17
- [RFC v4 59/70] target/riscv: rvv-1.0: remove vmford.vv and vmford.vf, frank . chang, 2020/08/17
- [RFC v4 57/70] target/riscv: rvv-1.0: single-width scaling shift instructions, frank . chang, 2020/08/17
- [RFC v4 58/70] target/riscv: rvv-1.0: remove widening saturating scaled multiply-add, frank . chang, 2020/08/17
- [RFC v4 60/70] target/riscv: rvv-1.0: remove integer extract instruction, frank . chang, 2020/08/17
- [RFC v4 61/70] target/riscv: rvv-1.0: floating-point min/max instructions, frank . chang, 2020/08/17