[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 34/45] target/arm: Implement fp16 for Neon VRSQRTS
From: |
Richard Henderson |
Subject: |
Re: [PATCH v2 34/45] target/arm: Implement fp16 for Neon VRSQRTS |
Date: |
Fri, 28 Aug 2020 16:03:27 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/28/20 11:33 AM, Peter Maydell wrote:
> Convert the Neon VRSQRTS insn to using a gvec helper,
> and use this to implement the fp16 case.
>
> As with VRECPS, we adjust the phrasing of the new implementation
> slightly so that the fp32 version parallels the fp16 one.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/helper.h | 4 +++-
> target/arm/vec_helper.c | 30 ++++++++++++++++++++++++++++++
> target/arm/vfp_helper.c | 15 ---------------
> target/arm/translate-neon.c.inc | 21 +--------------------
> 4 files changed, 34 insertions(+), 36 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- Re: [PATCH v2 30/45] target/arm: Implement fp16 for Neon VMLA, VMLS operations, (continued)
- [PATCH v2 29/45] target/arm: Implement fp16 for Neon VMAXNM, VMINNM, Peter Maydell, 2020/08/28
- [PATCH v2 31/45] target/arm: Implement fp16 for Neon VFMA, VMFS, Peter Maydell, 2020/08/28
- [PATCH v2 32/45] target/arm: Implement fp16 for Neon fp compare-vs-0, Peter Maydell, 2020/08/28
- [PATCH v2 33/45] target/arm: Implement fp16 for Neon VRECPS, Peter Maydell, 2020/08/28
- [PATCH v2 34/45] target/arm: Implement fp16 for Neon VRSQRTS, Peter Maydell, 2020/08/28
- Re: [PATCH v2 34/45] target/arm: Implement fp16 for Neon VRSQRTS,
Richard Henderson <=
- [PATCH v2 35/45] target/arm: Implement fp16 for Neon pairwise fp ops, Peter Maydell, 2020/08/28
- [PATCH v2 36/45] target/arm: Implement fp16 for Neon float-integer VCVT, Peter Maydell, 2020/08/28
- [PATCH v2 37/45] target/arm: Convert Neon VCVT fixed-point to gvec, Peter Maydell, 2020/08/28
- [PATCH v2 38/45] target/arm: Implement fp16 for Neon VCVT fixed-point, Peter Maydell, 2020/08/28
- [PATCH v2 39/45] target/arm: Implement fp16 for Neon VCVT with rounding modes, Peter Maydell, 2020/08/28