[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 7/8] Revert "hw/386: Add EPYC mode topology decoding funct
From: |
Babu Moger |
Subject: |
Re: [PATCH v5 7/8] Revert "hw/386: Add EPYC mode topology decoding functions" |
Date: |
Fri, 28 Aug 2020 13:03:59 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/28/20 12:27 PM, Eduardo Habkost wrote:
> On Fri, Aug 21, 2020 at 05:13:03PM -0500, Babu Moger wrote:
>> Remove the EPYC specific apicid decoding and use the generic
>> default decoding.
>>
>> This reverts commit 7568b205555a6405042f62c64af3268f4330aed5.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
> [...]
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index 19198e3e7f..b29686220e 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -388,7 +388,7 @@ static void encode_topo_cpuid8000001e(X86CPUTopoInfo
>> *topo_info, X86CPU *cpu,
>> unsigned long dies = topo_info->dies_per_pkg;
>> int shift;
>>
>> - x86_topo_ids_from_apicid_epyc(cpu->apic_id, topo_info, &topo_ids);
>> + x86_topo_ids_from_apicid(cpu->apic_id, topo_info, &topo_ids);
>
> This was not part of commit 7568b205555a6405042f62c64af3268f4330aed5.
> I suggest doing this change as a separate patch, to make review easier.
>
> That line was addd by commit dd08ef0318e2
> ("target/i386: Cleanup and use the EPYC mode topology functions").
> Wouldn't it be simpler to revert that commit? If there are parts
> of commit dd08ef0318e2 we want to keep, they can be re-added
> in a separate patch.
>
Sure. Will take care of it in next revision. Thanks.
- [PATCH v5 4/8] Revert "hw/i386: Move arch_id decode inside x86_cpus_init", (continued)
- [PATCH v5 4/8] Revert "hw/i386: Move arch_id decode inside x86_cpus_init", Babu Moger, 2020/08/21
- [PATCH v5 5/8] Revert "i386: Introduce use_epyc_apic_id_encoding in X86CPUDefinition", Babu Moger, 2020/08/21
- [PATCH v5 6/8] Revert "hw/i386: Introduce apicid functions inside X86MachineState", Babu Moger, 2020/08/21
- [PATCH v5 1/8] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology, Babu Moger, 2020/08/21
- [PATCH v5 2/8] Revert "i386: Fix pkg_id offset for EPYC cpu models", Babu Moger, 2020/08/21
- [PATCH v5 3/8] Revert "target/i386: Enable new apic id encoding for EPYC based cpus models", Babu Moger, 2020/08/21
- [PATCH v5 7/8] Revert "hw/386: Add EPYC mode topology decoding functions", Babu Moger, 2020/08/21
- [PATCH v5 8/8] i386: Simplify CPUID_8000_001E for AMD, Babu Moger, 2020/08/21
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Dr. David Alan Gilbert, 2020/08/24
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Babu Moger, 2020/08/24
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Dr. David Alan Gilbert, 2020/08/25
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Igor Mammedov, 2020/08/25
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Dr. David Alan Gilbert, 2020/08/25
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Igor Mammedov, 2020/08/26
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Dr. David Alan Gilbert, 2020/08/26
- Re: [PATCH v5 0/8] Remove EPYC mode apicid decode and use generic decode, Igor Mammedov, 2020/08/27