[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 69/76] target/microblaze: Tidy do_rti, do_rtb, do_rte
From: |
Richard Henderson |
Subject: |
[PATCH v2 69/76] target/microblaze: Tidy do_rti, do_rtb, do_rte |
Date: |
Fri, 28 Aug 2020 07:19:22 -0700 |
Since cpu_msr is no longer a 64-bit quantity, we can simplify
the arithmetic in these functions.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/microblaze/translate.c | 65 ++++++++++++++---------------------
1 file changed, 25 insertions(+), 40 deletions(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 6c1855b29a..0872795038 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1494,59 +1494,44 @@ static void dec_msr(DisasContext *dc)
}
}
-static inline void do_rti(DisasContext *dc)
+static void do_rti(DisasContext *dc)
{
- TCGv_i32 t0, t1;
- t0 = tcg_temp_new_i32();
- t1 = tcg_temp_new_i32();
- tcg_gen_mov_i32(t1, cpu_msr);
- tcg_gen_shri_i32(t0, t1, 1);
- tcg_gen_ori_i32(t1, t1, MSR_IE);
- tcg_gen_andi_i32(t0, t0, (MSR_VM | MSR_UM));
+ TCGv_i32 tmp = tcg_temp_new_i32();
- tcg_gen_andi_i32(t1, t1, ~(MSR_VM | MSR_UM));
- tcg_gen_or_i32(t1, t1, t0);
- msr_write(dc, t1);
- tcg_temp_free_i32(t1);
- tcg_temp_free_i32(t0);
+ tcg_gen_shri_i32(tmp, cpu_msr, 1);
+ tcg_gen_ori_i32(cpu_msr, cpu_msr, MSR_IE);
+ tcg_gen_andi_i32(tmp, tmp, MSR_VM | MSR_UM);
+ tcg_gen_andi_i32(cpu_msr, cpu_msr, ~(MSR_VM | MSR_UM));
+ tcg_gen_or_i32(cpu_msr, cpu_msr, tmp);
+
+ tcg_temp_free_i32(tmp);
dc->tb_flags &= ~DRTI_FLAG;
}
-static inline void do_rtb(DisasContext *dc)
+static void do_rtb(DisasContext *dc)
{
- TCGv_i32 t0, t1;
- t0 = tcg_temp_new_i32();
- t1 = tcg_temp_new_i32();
- tcg_gen_mov_i32(t1, cpu_msr);
- tcg_gen_andi_i32(t1, t1, ~MSR_BIP);
- tcg_gen_shri_i32(t0, t1, 1);
- tcg_gen_andi_i32(t0, t0, (MSR_VM | MSR_UM));
+ TCGv_i32 tmp = tcg_temp_new_i32();
- tcg_gen_andi_i32(t1, t1, ~(MSR_VM | MSR_UM));
- tcg_gen_or_i32(t1, t1, t0);
- msr_write(dc, t1);
- tcg_temp_free_i32(t1);
- tcg_temp_free_i32(t0);
+ tcg_gen_shri_i32(tmp, cpu_msr, 1);
+ tcg_gen_andi_i32(cpu_msr, cpu_msr, ~(MSR_VM | MSR_UM | MSR_BIP));
+ tcg_gen_andi_i32(tmp, tmp, (MSR_VM | MSR_UM));
+ tcg_gen_or_i32(cpu_msr, cpu_msr, tmp);
+
+ tcg_temp_free_i32(tmp);
dc->tb_flags &= ~DRTB_FLAG;
}
-static inline void do_rte(DisasContext *dc)
+static void do_rte(DisasContext *dc)
{
- TCGv_i32 t0, t1;
- t0 = tcg_temp_new_i32();
- t1 = tcg_temp_new_i32();
+ TCGv_i32 tmp = tcg_temp_new_i32();
- tcg_gen_mov_i32(t1, cpu_msr);
- tcg_gen_ori_i32(t1, t1, MSR_EE);
- tcg_gen_andi_i32(t1, t1, ~MSR_EIP);
- tcg_gen_shri_i32(t0, t1, 1);
- tcg_gen_andi_i32(t0, t0, (MSR_VM | MSR_UM));
+ tcg_gen_shri_i32(tmp, cpu_msr, 1);
+ tcg_gen_ori_i32(cpu_msr, cpu_msr, MSR_EE);
+ tcg_gen_andi_i32(tmp, tmp, (MSR_VM | MSR_UM));
+ tcg_gen_andi_i32(cpu_msr, cpu_msr, ~(MSR_VM | MSR_UM | MSR_EIP));
+ tcg_gen_or_i32(cpu_msr, cpu_msr, tmp);
- tcg_gen_andi_i32(t1, t1, ~(MSR_VM | MSR_UM));
- tcg_gen_or_i32(t1, t1, t0);
- msr_write(dc, t1);
- tcg_temp_free_i32(t1);
- tcg_temp_free_i32(t0);
+ tcg_temp_free_i32(tmp);
dc->tb_flags &= ~DRTE_FLAG;
}
--
2.25.1
- [PATCH v2 59/76] target/microblaze: Use cc->do_unaligned_access, (continued)
- [PATCH v2 59/76] target/microblaze: Use cc->do_unaligned_access, Richard Henderson, 2020/08/28
- [PATCH v2 60/76] target/microblaze: Replace clear_imm with tb_flags_to_set, Richard Henderson, 2020/08/28
- [PATCH v2 63/76] target/microblaze: Convert brk and brki to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 64/76] target/microblaze: Convert mbar to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 62/76] target/microblaze: Tidy mb_cpu_dump_state, Richard Henderson, 2020/08/28
- [PATCH v2 61/76] target/microblaze: Replace delayed_branch with tb_flags_to_set, Richard Henderson, 2020/08/28
- [PATCH v2 65/76] target/microblaze: Reorganize branching, Richard Henderson, 2020/08/28
- [PATCH v2 66/76] target/microblaze: Convert dec_br to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 68/76] target/microblaze: Convert dec_rts to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 67/76] target/microblaze: Convert dec_bcc to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 69/76] target/microblaze: Tidy do_rti, do_rtb, do_rte,
Richard Henderson <=
- [PATCH v2 71/76] target/microblaze: Convert dec_msr to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 70/76] target/microblaze: Convert msrclr, msrset to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 72/76] target/microblaze: Convert dec_stream to decodetree, Richard Henderson, 2020/08/28
- [PATCH v2 73/76] target/microblaze: Remove last of old decoder, Richard Henderson, 2020/08/28
- [PATCH v2 75/76] target/microblaze: Add flags markup to some helpers, Richard Henderson, 2020/08/28
- [PATCH v2 74/76] target/microblaze: Remove cpu_R[0], Richard Henderson, 2020/08/28
- [PATCH v2 76/76] target/microblaze: Reduce linux-user address space to 32-bit, Richard Henderson, 2020/08/28
- Re: [PATCH v2 00/76] target/microblaze improvements, Edgar E. Iglesias, 2020/08/31