[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated
From: |
Mark Cave-Ayland |
Subject: |
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja |
Date: |
Thu, 27 Aug 2020 17:05:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 26/08/2020 07:45, Paolo Bonzini wrote:
> On Tue, Aug 25, 2020 at 11:26 PM Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk> wrote:
>> I've tested this and it changes build.ninja so instead of Windows paths
>> beginning C$$
>> they now begin C$ instead e.g.:
>>
>> build qemu-version.h: CUSTOM_COMMAND |
>> C$:/msys64/home/Mark/qemu/scripts/qemu-version.sh PHONY
>
> The patch should not change build.ninja in any way, but indeed it will
> fix the transformation so that the (correct) ninja quoting is removed.
It definitely changes build.ninja here, with the escaping changing from C$$:\
to C$:\
in my tests. But if you're saying that $: with just a single $ is the correct
escaping for colon then I guess the patch is fine (and indeed it works for me
with
the $ now being removed in the transformation to Makefile.ninja).
ATB,
Mark.
- Re: [PATCH 2/4] meson: fixes relpath may fail on win32., (continued)
[PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2, luoyonggang, 2020/08/25
[PATCH 4/4] configure: Fix include and linkage issue on msys2, luoyonggang, 2020/08/25
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, Mark Cave-Ayland, 2020/08/25
Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, Eric Blake, 2020/08/25