[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(
From: |
Chen Qun |
Subject: |
[PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path() |
Date: |
Thu, 27 Aug 2020 19:03:09 +0800 |
Clang static code analyzer show warning:
qemu/hw/usb/bus.c:615:13: warning: Value stored to 'pos' is never read
pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
v2->v3: The format of the snprintf statement is modified(Base on Markus review).
---
hw/usb/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/bus.c b/hw/usb/bus.c
index b17bda3b29..2b11041451 100644
--- a/hw/usb/bus.c
+++ b/hw/usb/bus.c
@@ -612,8 +612,8 @@ static char *usb_get_fw_dev_path(DeviceState *qdev)
in++;
} else {
/* the device itself */
- pos += snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
- qdev_fw_name(qdev), nr);
+ snprintf(fw_path + pos, fw_len - pos, "%s@%lx",
+ qdev_fw_name(qdev), nr);
break;
}
}
--
2.23.0
- [PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), (continued)
- [PATCH v3 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Chen Qun, 2020/08/27
- [PATCH v3 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(), Chen Qun, 2020/08/27
- [PATCH v3 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Chen Qun, 2020/08/27
- [PATCH v3 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Chen Qun, 2020/08/27
- [PATCH v3 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(), Chen Qun, 2020/08/27
- [PATCH v3 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Chen Qun, 2020/08/27
- [PATCH v3 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions(), Chen Qun, 2020/08/27
- [PATCH v3 09/10] hw/intc: fix default registers value in exynos4210_combiner_read(), Chen Qun, 2020/08/27
- [PATCH v3 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Chen Qun, 2020/08/27
- [PATCH v3 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(),
Chen Qun <=