[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: oslib-posix:Fix handle fd leak in qemu_write_pidfile()
From: |
AlexChen |
Subject: |
Re: oslib-posix:Fix handle fd leak in qemu_write_pidfile() |
Date: |
Thu, 27 Aug 2020 10:40:39 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 |
On 2020/8/26 18:18, Daniel P. Berrangé wrote:
> On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote:
>> > From: alexchen <alex.chen@huawei.com>
>> >
>> > The fd will leak when (a.st_ino == b.st_ino) is true, fix it.
> That is *INTENTIONAL*. We're holding a lock on the file and the
> lock exists only while the FD is open. When QEMU exists, the FD
> is closed and the lock is released. There is no leak.
>
OK, I got it, thanks.
Thanks
Alex