[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses
From: |
Helge Deller |
Subject: |
[PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses |
Date: |
Wed, 26 Aug 2020 23:13:43 +0200 |
Commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes
in memory_region_access_valid") broke the artist driver in a way that
the dtwm window manager on HP-UX rendered wrong.
Fixes: 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in
memory_region_access_valid")
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Signed-off-by: Helge Deller <deller@gmx.de>
---
hw/display/artist.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/display/artist.c b/hw/display/artist.c
index 46eaa10dae..44bb67bbc3 100644
--- a/hw/display/artist.c
+++ b/hw/display/artist.c
@@ -1237,20 +1237,16 @@ static const MemoryRegionOps artist_reg_ops = {
.read = artist_reg_read,
.write = artist_reg_write,
.endianness = DEVICE_NATIVE_ENDIAN,
- .valid = {
- .min_access_size = 1,
- .max_access_size = 4,
- },
+ .impl.min_access_size = 1,
+ .impl.max_access_size = 4,
};
static const MemoryRegionOps artist_vram_ops = {
.read = artist_vram_read,
.write = artist_vram_write,
.endianness = DEVICE_NATIVE_ENDIAN,
- .valid = {
- .min_access_size = 1,
- .max_access_size = 4,
- },
+ .impl.min_access_size = 1,
+ .impl.max_access_size = 4,
};
static void artist_draw_cursor(ARTISTState *s)
--
2.21.3
- [PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:, Helge Deller, 2020/08/26
- [PULL v5 01/12] hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources, Helge Deller, 2020/08/26
- [PULL v5 05/12] hw/hppa/lasi: Don't abort on invalid IMR value, Helge Deller, 2020/08/26
- [PULL v5 08/12] Revert "hw/display/artist: Avoid drawing line when nothing to display", Helge Deller, 2020/08/26
- [PULL v5 07/12] hw/display/artist: Refactor artist_rop8() to avoid buffer over-run, Helge Deller, 2020/08/26
- [PULL v5 09/12] hw/display/artist: Prevent out of VRAM buffer accesses, Helge Deller, 2020/08/26
- [PULL v5 10/12] hw/display/artist: Unbreak size mismatch memory accesses,
Helge Deller <=
- [PULL v5 11/12] hw/display/artist: Fix invalidation of lines in artist_draw_line(), Helge Deller, 2020/08/26
- [PULL v5 12/12] hw/display/artist: Fix invalidation of lines near screen border, Helge Deller, 2020/08/26
- [PULL v5 03/12] hw/hppa: Implement proper SeaBIOS version check, Helge Deller, 2020/08/26
- [PULL v5 06/12] hw/display/artist: Check offset in draw_line to avoid buffer over-run, Helge Deller, 2020/08/26
- [PULL v5 02/12] seabios-hppa: Update to SeaBIOS hppa version 1, Helge Deller, 2020/08/26
- [PULL v5 04/12] hw/display/artist.c: fix out of bounds check, Helge Deller, 2020/08/26
- Re: [PULL v5 00/12] The following changes since commit 3461487523b897d324e8d91f3fd20ed55f849544:, Peter Maydell, 2020/08/27