[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v5 4/6] configure: Fix include and linkage issue on msys2 |
Date: |
Wed, 26 Aug 2020 17:36:01 +0200 |
On Wed, Aug 26, 2020 at 5:33 PM 罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> wrote:
>
>
> On Wed, Aug 26, 2020 at 11:24 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>> I'm a bit wary of this patch, the effects are quite wide-ranging. If
>> we move all the detection of dependencies to meson, it will take a
>> while but we should get a similar effect.
>
> Only on MINGW the $PWD sematic are changed, so I don't think there is side
> effect of this patch.
Yes the side effect is only on MINGW but the affected variables are
used everywhere so it's a rather hard to review change.
Paolo
[PATCH v5 5/6] meson: Fixes ninjatool can not be recognized as script under Window/MSYS2, luoyonggang, 2020/08/26
[PATCH v5 6/6] meson: Convert undefsym.sh to undefsym.py, luoyonggang, 2020/08/26
Re: [PATCH v5 1/6] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja, Paolo Bonzini, 2020/08/26