[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_stri
From: |
Li Qiang |
Subject: |
Re: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string |
Date: |
Wed, 26 Aug 2020 18:37:49 +0800 |
Pan Nengyuan <pannengyuan@huawei.com> 于2020年8月14日周五 下午6:40写道:
>
> 'addr' forgot to free in vnc_socket_ip_addr_string error path. Fix that.
s/forgot/is forgot, I think the maintainer will do this minor adjustment.
.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ui/vnc-auth-sasl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
> index 7b2b09f242..0517b2ead9 100644
> --- a/ui/vnc-auth-sasl.c
> +++ b/ui/vnc-auth-sasl.c
> @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc,
>
> if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
> error_setg(errp, "Not an inet socket type");
> + qapi_free_SocketAddress(addr);
> return NULL;
> }
> ret = g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port);
> --
> 2.18.2
>
>
- [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, (continued)
- [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Pan Nengyuan, 2020/08/14
- [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Pan Nengyuan, 2020/08/14
- [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Pan Nengyuan, 2020/08/14
- [PATCH 12/12] test-util-sockets: Fix a memleak in test_socket_unix_abstract_good, Pan Nengyuan, 2020/08/14
- [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string, Pan Nengyuan, 2020/08/14
- Re: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string,
Li Qiang <=
- [PATCH 10/12] block/file-posix: fix a possible undefined behavior, Pan Nengyuan, 2020/08/14
- Re: [PATCH 00/12] fix some error memleaks, Pan Nengyuan, 2020/08/26