[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM |
Date: |
Wed, 26 Aug 2020 11:23:32 +0200 |
On Tue, 25 Aug 2020 19:25:48 +0200
Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/18/20 14:22, Igor Mammedov wrote:
> > In case firmware has negotiated CPU hotplug SMI feature, generate
> > AML to describe SMI IO port region and send SMI to firmware
> > on each CPU hotplug SCI in case new CPUs were hotplugged.
> >
> > Since new CPUs can be hotplugged while CPU_SCAN_METHOD is running
> > we can't send SMI before new CPUs are fetched from QEMU as it
> > could cause sending Notify to a CPU that firmware hasn't seen yet.
> > So fetch new CPUs into local cache first and then send SMI and
> > after that sends Notify events to cached CPUs. This should ensure
> > that Notify is sent only to CPUs which were processed by firmware
> > first.
> > Any CPUs that were hotplugged after caching will be processed
> > by the next CPU_SCAN_METHOD, when pending SCI is handled.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > v2:
> > - clear insert event after firmware has returned
> > control from SMI. (Laszlo Ersek <lersek@redhat.com>)
Laszlo,
Thanks a lot for such detailed review
I'll respin series with your feed back incorporated.
[...]
- Re: [PATCH v4 1/6] x86: lpc9: let firmware negotiate 'CPU hotplug with SMI' features, (continued)
- [PATCH v2 2/7] x86: cphp: prevent guest crash on CPU hotplug when broadcast SMI is in use, Igor Mammedov, 2020/08/18
- [PATCH v2 3/7] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported, Igor Mammedov, 2020/08/18
- [PATCH v2 4/7] acpi: add aml_land() and aml_break() primitives, Igor Mammedov, 2020/08/18
- [PATCH v2 5/7] tests: acpi: mark to be changed tables in bios-tables-test-allowed-diff, Igor Mammedov, 2020/08/18
- [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM, Igor Mammedov, 2020/08/18
[PATCH v2 7/7] tests: acpi: update acpi blobs with new AML, Igor Mammedov, 2020/08/18
Re: [PATCH v2 0/7] x86: fix cpu hotplug with secure boot, no-reply, 2020/08/18
Re: [PATCH v2 0/7] x86: fix cpu hotplug with secure boot, no-reply, 2020/08/18