[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 02/34] Hexagon (target/hexagon) README
From: |
Richard Henderson |
Subject: |
Re: [RFC PATCH v3 02/34] Hexagon (target/hexagon) README |
Date: |
Tue, 25 Aug 2020 19:06:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/18/20 8:50 AM, Taylor Simpson wrote:
> + #ifdef fGEN_TCG_A2_add
> + fGEN_TCG_A2_add({ RdV=RsV+RtV;});
> + #else
> + do {
> + gen_helper_A2_add(RdV, cpu_env, RsV, RtV);
> + } while (0);
I don't understand the benefit of passing the SHORTCODE to fGEN_TCG_*. Is this
file included for helper generation?
It seems to contradict what you have a few lines lower
> +The gen_tcg.h file has any overrides. For example,
> + #define fGEN_TCG_A2_add(GENHLPR, SHORTCODE) \
> + tcg_gen_add_tl(RdV, RsV, RtV)
which has two arguments not one.
Is this README out of date?
r~
- Re: [RFC PATCH v3 15/34] Hexagon (target/hexagon) instruction printing, (continued)
- [RFC PATCH v3 05/34] Hexagon (target/hexagon) register names, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 06/34] Hexagon (disas) disassembler, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 11/34] Hexagon (target/hexagon) register fields, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 02/34] Hexagon (target/hexagon) README, Taylor Simpson, 2020/08/18
- Re: [RFC PATCH v3 02/34] Hexagon (target/hexagon) README,
Richard Henderson <=
- [RFC PATCH v3 03/34] Hexagon (include/elf.h) ELF machine definition, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 13/34] Hexagon (target/hexagon) register map, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 14/34] Hexagon (target/hexagon) instruction/packet decode, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 07/34] Hexagon (target/hexagon) scalar core helpers, Taylor Simpson, 2020/08/18