qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: set colorout to auto


From: Marc-André Lureau
Subject: Re: [PATCH] meson: set colorout to auto
Date: Tue, 25 Aug 2020 10:59:42 +0400

Hi

On Tue, Aug 25, 2020 at 10:44 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
Dunno why the default is set to "always".  IMHO it should be "auto",
i.e. only colorize in case stdout goes to a terminal.  Cluttering
logfiles and confusing compiler message parsers with terminal control
sequences is not nice ...

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

"Enable colored output with GCC. Ninja redirects stdout/stderr so by default GCC thinks it is not talking to a terminal"

https://github.com/mesonbuild/meson/commit/4f63fe498314c385de2d3b6a3a953d15985914d2

Since we use make, I don't know if it's any better.

Perhaps meson should set compiler/tools colors = always/never based on what it is connected to at configure time instead?

--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]