[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_c
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new |
|
Date: |
Mon, 17 Aug 2020 17:56:16 +0100 |
|
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Wed, Aug 12, 2020 at 08:25:29PM -0700, Richard Henderson wrote:
> The class vtable should be set by the class initializer.
> This will also allow additional subclassing, reducing the
> amount of indirection in the hierarchy.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> crypto/cipherpriv.h | 2 --
> crypto/cipher-afalg.c | 5 ++++-
> crypto/cipher-builtin.inc.c | 4 ++++
> crypto/cipher-gcrypt.inc.c | 2 ++
> crypto/cipher-nettle.inc.c | 3 +++
> crypto/cipher.c | 7 -------
> 6 files changed, 13 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 05/17] crypto: Remove redundant includes, (continued)
- [PATCH 06/17] crypto/nettle: Fix xts_encrypt arguments, Richard Henderson, 2020/08/12
- [PATCH 07/17] crypto: Use the correct const type for driver, Richard Henderson, 2020/08/12
- [PATCH 08/17] crypto: Allocate QCryptoCipher with the subclass, Richard Henderson, 2020/08/12
- [PATCH 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new, Richard Henderson, 2020/08/12
- Re: [PATCH 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new,
Daniel P . Berrangé <=
- [PATCH 10/17] crypto: Constify cipher data tables, Richard Henderson, 2020/08/12
- [PATCH 11/17] crypto/builtin: Remove odd-sized AES block handling, Richard Henderson, 2020/08/12
- [PATCH 12/17] crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt, Richard Henderson, 2020/08/12
- [PATCH 13/17] crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c, Richard Henderson, 2020/08/12