Re: [PATCH v8 10/20] multi-process: setup memory manager for remote device

[Stefan Hajnoczi]

On Fri, Jul 31, 2020 at 02:20:17PM -0400, Jagannathan Raman wrote:
> +    QTAILQ_FOREACH_SAFE(subregion, &sysmem->subregions, subregions_link, 
> next) {
> +        if (subregion->ram) {
> +            memory_region_del_subregion(sysmem, subregion);
> +            object_unparent(OBJECT(subregion));
> +        }
> +    }

Where is g_free(subregion) called?

> +
> +    for (region = 0; region < msg->num_fds; region++) {
> +        subregion = g_new(MemoryRegion, 1);
> +        name = g_strdup_printf("remote-mem-%u", suffix++);
> +        memory_region_init_ram_from_fd(subregion, NULL,
> +                                       name, sysmem_info->sizes[region],
> +                                       RAM_SHARED, msg->fds[region],
> +                                       sysmem_info->offsets[region],
> +                                       &local_err);
> +        g_free(name);
> +        if (local_err) {
> +            error_propagate(errp, local_err);
> +            break;

Where is g_free(subregion) called?

signature.asc
Description: PGP signature