[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] block: add logging facility for long standing IO request
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 2/2] block: add logging facility for long standing IO requests |
Date: |
Fri, 31 Jul 2020 11:23:23 +0100 |
On Wed, Jul 29, 2020 at 02:06:43PM +0300, Denis V. Lunev wrote:
> On 7/29/20 1:30 PM, Stefan Hajnoczi wrote:
> > On Fri, Jul 10, 2020 at 08:27:11PM +0300, Denis V. Lunev wrote:
> >> @@ -3740,6 +3741,10 @@ QemuOptsList qemu_common_drive_opts = {
> >> .type = QEMU_OPT_BOOL,
> >> .help = "whether to account for failed I/O operations "
> >> "in the statistics",
> >> + },{
> >> + .name = "latency-log-threshold",
> >> + .type = QEMU_OPT_STRING,
> > QEMU_OPT_NUMBER?
> good catch! we have this parameter on by default (10 seconds) and never
> passed it from the command line :)
>
> Thus should we keep this off be default or on? :)
On by default sounds good. It adds useful information.
Stefan
signature.asc
Description: PGP signature