[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/16] hw/block/nvme: consolidate qsg/iov clearing
From: |
Minwoo Im |
Subject: |
Re: [PATCH 14/16] hw/block/nvme: consolidate qsg/iov clearing |
Date: |
Thu, 30 Jul 2020 01:08:55 +0900 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On 20-07-20 13:37:46, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Always destroy the request qsg/iov at the end of request use.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/block/nvme.c | 48 +++++++++++++++++-------------------------------
> 1 file changed, 17 insertions(+), 31 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 54cd20f1ce22..b53afdeb3fb6 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -213,6 +213,14 @@ static void nvme_req_clear(NvmeRequest *req)
> {
> req->ns = NULL;
> memset(&req->cqe, 0x0, sizeof(req->cqe));
> +
> + if (req->qsg.sg) {
> + qemu_sglist_destroy(&req->qsg);
> + }
> +
> + if (req->iov.iov) {
> + qemu_iovec_destroy(&req->iov);
> + }
Oh okay. This looks like update for the previous patch in this series.
And I also agree on starting to make focus on nvme_req_clear() for
wrap-up.
Looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
- Re: [PATCH 11/16] hw/block/nvme: be consistent about zeros vs zeroes, (continued)
- [PATCH 12/16] hw/block/nvme: refactor NvmeRequest clearing, Klaus Jensen, 2020/07/20
- [PATCH 16/16] hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp, Klaus Jensen, 2020/07/20
- [PATCH 14/16] hw/block/nvme: consolidate qsg/iov clearing, Klaus Jensen, 2020/07/20
- [PATCH 15/16] hw/block/nvme: remove NvmeCmd parameter, Klaus Jensen, 2020/07/20
- [PATCH 13/16] hw/block/nvme: add a namespace reference in NvmeRequest, Klaus Jensen, 2020/07/20