Re: [PATCH v2 2/3] linux-user: Add missing termbits types and values definitions

[Max Filippov]

On Thu, Jul 23, 2020 at 2:25 PM Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> On Thu, Jul 23, 2020 at 2:04 PM Filip Bozuta <Filip.Bozuta@syrmia.com> wrote:
> >
> > This patch introduces missing target types ('target_flag_t', 'target_cc_t',
> > 'target_speed_t') in a few 'termibts.h' header files. Also, two missing
> > values ('TARGET_IUTF8' and 'TARGET_EXTPROC') were also added. These values
> > were also added in file 'syscall.c' in bitmask tables 'iflag_tbl[]' and
> > 'lflag_tbl[]' which are used to convert values of 'struct termios' between
> > target and host.
> >
> > Signed-off-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
> > ---
> >  linux-user/alpha/termbits.h   |  1 +
> >  linux-user/cris/termbits.h    | 18 ++++++++----
> >  linux-user/hppa/termbits.h    | 17 +++++++----
> >  linux-user/mips/termbits.h    | 17 +++++++----
> >  linux-user/ppc/termbits.h     | 21 ++++++++------
> >  linux-user/sh4/termbits.h     | 19 +++++++++----
> >  linux-user/sparc/termbits.h   | 18 ++++++++----
> >  linux-user/sparc64/termbits.h | 18 ++++++++----
> >  linux-user/syscall.c          | 34 +++++++++++-----------
> >  linux-user/xtensa/termbits.h  | 53 ++++++++++++++++++-----------------
> >  10 files changed, 130 insertions(+), 86 deletions(-)
>
> Curious why you did it to some targets, but not to others?
> E.g. the following headers have similar definitions:
> linux-user/aarch64/termbits.h
> linux-user/arm/termbits.h
> linux-user/i386/termbits.h
> linux-user/m68k/termbits.h
> linux-user/microblaze/termbits.h
> linux-user/nios2/termbits.h
> linux-user/riscv/termbits.h
> linux-user/s390x/termbits.h
> linux-user/tilegx/termbits.h

Never mind, I got this email before the other that adds generic headers...

Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>

-- 
Thanks.
-- Max