[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ehci: drop pointless warn_report for guest bugs.
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] ehci: drop pointless warn_report for guest bugs. |
|
Date: |
Wed, 22 Jul 2020 09:50:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/22/20 9:26 AM, Gerd Hoffmann wrote:
> We have a tracepoint at the same place which can be enabled if needed.
>
> Buglink: https://bugzilla.redhat.com//show_bug.cgi?id=1859236
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/usb/hcd-ehci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
> index 1495e8f7fab1..4266765f8682 100644
> --- a/hw/usb/hcd-ehci.c
> +++ b/hw/usb/hcd-ehci.c
> @@ -352,7 +352,6 @@ static void ehci_trace_sitd(EHCIState *s, hwaddr addr,
> static void ehci_trace_guest_bug(EHCIState *s, const char *message)
> {
> trace_usb_ehci_guest_bug(message);
> - warn_report("%s", message);
> }
>
> static inline bool ehci_enabled(EHCIState *s)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>