Re: [PATCH] virtio: Drop broken and superfluous object_property_set_link()

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 7/21/20 2:11 PM, Markus Armbruster wrote:
>
> Is there a line missing here?
>
>> virtio_crypto_pci_realize() and copies the value of vcrypto->vdev's
>
>                               ^^^
>

Scratch "and".  I started describing two of the four cases together,
then changed my mind and described just one, keeping other three under
"Same for" below.  I accidentally left the "and" behind.

>> property "cryptodev" to vcrypto's property:
>> 
>>     object_property_set_link(OBJECT(vrng), "rng", 
>> OBJECT(vrng->vdev.conf.rng),
>>                              NULL);
>> 
>> Since it does so only after realize, this always fails, but the error
>> is ignored.
>> 
>> It's actually superfluous: vcrypto's property is an alias of
>> vcrypto->vdev's property, created by virtio_instance_init_common().
>> 
>> Drop the call.
>> 
>> Same for virtio_ccw_crypto_realize(), virtio_rng_pci_realize(),
>> virtio_ccw_rng_realize().
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>