[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] scripts/tracetool: Use void pointer for vcpu
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v2 2/4] scripts/tracetool: Use void pointer for vcpu |
Date: |
Tue, 21 Jul 2020 13:34:01 +0100 |
On Fri, Jul 17, 2020 at 12:35:15PM +0300, Roman Bolshakov wrote:
> dtrace on macOS complains that CPUState * is used for a few probes:
>
> dtrace: failed to compile script trace-dtrace-root.dtrace: line 130: syntax
> error near "CPUState"
>
> A comment in scripts/tracetool/__init__.py mentions that:
>
> We only want to allow standard C types or fixed sized
> integer types. We don't want QEMU specific types
> as we can't assume trace backends can resolve all the
> typedefs
>
> Fixes: 3d211d9f4dbee ("trace: Add 'vcpu' event property to trace guest vCPU")
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Cameron Esfahani <dirty@apple.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> scripts/tracetool/vcpu.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature