[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/10] fuzz: build without AddressSanitizer, by default
From: |
Thomas Huth |
Subject: |
[PULL 04/10] fuzz: build without AddressSanitizer, by default |
Date: |
Tue, 21 Jul 2020 10:10:49 +0200 |
From: Alexander Bulekov <alxndr@bu.edu>
We already have a nice --enable-sanitizers option to enable
AddressSanitizer. There is no reason to duplicate and force this
functionality in --enable-fuzzing. In the future, if more sanitizers are
added to --enable-sanitizers, it might be impossible to build with both
--enable-sanitizers and --enable-fuzzing, since not all sanitizers are
compatible with libFuzzer. In that case, we could enable ASAN with
--extra-cflags="-fsanitize=address"
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200706195534.14962-2-alxndr@bu.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
[thuth: Added missing $CFLAGS]
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 33cee41f9c..4bd80ed507 100755
--- a/configure
+++ b/configure
@@ -6337,7 +6337,7 @@ fi
# checks for fuzzer
if test "$fuzzing" = "yes" ; then
write_c_fuzzer_skeleton
- if compile_prog "$CPU_CFLAGS -Werror -fsanitize=address,fuzzer" ""; then
+ if compile_prog "$CPU_CFLAGS -Werror -fsanitize=fuzzer" ""; then
have_fuzzer=yes
fi
fi
@@ -7893,11 +7893,11 @@ if test "$have_mlockall" = "yes" ; then
fi
if test "$fuzzing" = "yes" ; then
if test "$have_fuzzer" = "yes"; then
- FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
- FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
- CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"
+ FUZZ_LDFLAGS=" -fsanitize=fuzzer"
+ FUZZ_CFLAGS=" -fsanitize=fuzzer"
+ CFLAGS="$CFLAGS -fsanitize=fuzzer-no-link"
else
- error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
+ error_exit "Your compiler doesn't support -fsanitize=fuzzer"
exit 1
fi
fi
--
2.18.1
- [PULL 00/10] qtest / fuzzer patches, Thomas Huth, 2020/07/21
- [PULL 01/10] scripts/oss-fuzz: Limit target list to i386-softmmu, Thomas Huth, 2020/07/21
- [PULL 02/10] fuzz: Fix leak when assembling datadir path string, Thomas Huth, 2020/07/21
- [PULL 03/10] gitlab-ci.yml: Add oss-fuzz build tests, Thomas Huth, 2020/07/21
- [PULL 04/10] fuzz: build without AddressSanitizer, by default,
Thomas Huth <=
- [PULL 05/10] docs/fuzz: describe building fuzzers with enable-sanitizers, Thomas Huth, 2020/07/21
- [PULL 07/10] docs/fuzz: add instructions for generating a coverage report, Thomas Huth, 2020/07/21
- [PULL 06/10] docs/fuzz: add information about useful libFuzzer flags, Thomas Huth, 2020/07/21
- [PULL 10/10] hw: Mark nd_table[] misuse in realize methods FIXME, Thomas Huth, 2020/07/21
- [PULL 08/10] MAINTAINERS: Extend the device fuzzing section, Thomas Huth, 2020/07/21
- [PULL 09/10] msf2: Unbreak device-list-properties for "msf-soc", Thomas Huth, 2020/07/21
- Re: [PULL 00/10] qtest / fuzzer patches, Peter Maydell, 2020/07/21